Repository navigation
Fix Datepicker TypeError crash by clearing pending hide timeout on dispose - #43254
Open
ShakilUrRehman21 wants to merge 1 commit into
Open
ShakilUrRehman21 wants to merge 1 commit into
ShakilUrRehman21 wants to merge 1 commit into
Conversation
julien-deramond
added
v6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When selecting a date in
singleormultiple-rangedmode,_maybeHideAfterSelectionqueuessetTimeout(() => this.hide(), HIDE_DELAY).If
dispose()was called within the 300ms delay, the timer executedthis.hide()on the disposed instance (this._config === null), throwingTypeError: Cannot read properties of null (reading 'inline').Changes
this._hideTimeout.dispose(), clearthis._hideTimeout.hide(), clearthis._hideTimeoutand add a defensive check before readingthis._config.dispose()clears the pending hide timer without throwing.