Read one plain source.Package after the load

[crhntr]

Adds internal/source, a plain-data source.Package, which internal/load hydrates from a command's configuration. muxt, generate and analysis read only that. Imports on source.Package is temporary; the next PR removes it.

Part 3 of 8, stacked on #147. Replaces #145.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UjkpA4fvZ7xQAsY65Beprp

[Copilot]

🟡 Changes recommended

internal/analysis/check.go has an unresolved moderate issue affecting definition source spans.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR introduces source.Package as a plain-data boundary and updates loading, generation, analysis, routing, and CLI wiring to use hydrated source data.

Changes:

• Adds source models and hydration helpers.
• Refactors Muxt, generation, and analysis to consume hydrated packages.
• Updates tests, CLI wiring, and architecture documentation.

File summaries

File	Summary
internal/source/source.go	Defines plain source package, variable, definition, and call data.
internal/muxt/unmarshal.go	Uses source package imports for type detection. Nit: group third-party imports before internal imports.
internal/muxt/name_error_test.go	Adapts name-position testing.
internal/muxt/definition.go	Resolves definitions from source variables.
internal/muxt/definition_test.go	Updates definition tests.
internal/muxt/definition_internal_test.go	Updates internal definition tests. Nit: separate third-party and internal imports.
internal/muxt/call.go	Resolves calls from source.Package.
internal/muxt/call_test.go	Updates call resolution tests. Nit: separate third-party and internal imports.
internal/muxt/call_internal_test.go	Updates internal call tests.
internal/load/templates_test.go	Tests source hydration and directory handling.
internal/load/source.go	Hydrates loaded packages into source data.
internal/load/package.go	Adds directory-based package lookup.
internal/load/hydrate.go	Hydrates command-specific configurations.
internal/generate/validation_test.go	Simplifies generator test setup.
internal/generate/template_route_path.go	Reads encoding types from source imports.
internal/generate/routes.go	Generates routes from source packages.
internal/generate/groups.go	Groups source template variables.
internal/generate/file.go	Stores source package data in generated files.
internal/generate/file_test.go	Updates file and import tests.
internal/cli/commands.go	Wires CLI commands through hydration.
internal/astgen/gen.go	Simplifies the import manager interface.
internal/asteval/parse.go	Uses typed function maps.
internal/analysis/template_calls.go	Analyzes hydrated template calls.
internal/analysis/template_callers.go	Analyzes hydrated template callers.
internal/analysis/routes.go	Lists routes from source packages.
internal/analysis/check.go	Checks hydrated template data. Moderate: newGlobal leaves check.Global.Definitions nil, discarding stored source spans.
CLAUDE.md	Documents the new architecture.

Review details

Suppressed comments (2)

internal/muxt/definition_internal_test.go:12

• Please add the blank line separating third-party imports from internal/... imports, as established by the neighboring Muxt tests. This newly added import currently leaves the two groups merged.

	"github.com/typelate/muxt/internal/source"

internal/muxt/unmarshal.go:13

• Keep third-party imports together before the blank line for internal packages. This change places internal/source between github.com/typelate/dom and golang.org/x/net/html, unlike the established grouping in internal/generate/routes.go:17-22.

	"github.com/typelate/dom"
	"github.com/typelate/muxt/internal/source"
	"golang.org/x/net/html"
	"golang.org/x/net/html/atom"

• Files reviewed: 27/27 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

Only minor import-grouping nits remain, with no blocking issues.

Review details

Suppressed comments (2)

internal/analysis/template_callers.go:14

• Please keep the new internal import in the established import group: third-party imports are followed by a blank line before internal/... imports. The current block places internal/source directly after github.com/typelate/check, unlike the grouping used throughout the repository.

	"github.com/typelate/check"
	"github.com/typelate/muxt/internal/source"
)

internal/analysis/template_calls.go:14

• Please keep the new internal import in the established import group: third-party imports are followed by a blank line before internal/... imports. The current block places internal/source directly after github.com/typelate/check, unlike the grouping used throughout the repository.

	"github.com/typelate/check"
	"github.com/typelate/muxt/internal/source"
)

• Files reviewed: 27/27 changed files
• Comments generated: 1
• Review effort level: Lite