Skip to content

ImanageManager doesn't load new images #928

Description

@jumbosushi

What behavior were you expecting?

When I scroll toward the bottom of the images inside ImageManager (aka Image Modal), it should request new images & reload UI

What actually happened?

While there is a new request happening, it's now updating the UI. It is stuck with "Loading ..." then keep making requests

load_error

Steps to reproduce

  1. Open new article editor: https://www.ubyssey.ca/admin/articles/new/
  2. Click on Featured Image tab
  3. Click on "Select Image" button
  4. Within the ImageManager modal, scroll all the way down

What was your environment like?

Chrome on Ubuntu 16.04

Ideas

The main logic is in modals/ImageManager/index.js. The component seems to correctly detect & fetch new images, but not updating the UI. I suspect it's the this.props.images not being properly updated

Check out this line to see how images are being rendered

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions