Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89
Root cause
StarterKit omits the Link (and Underline) marks
Changes
StarterKit(configurable/disableable like the other bundled extensions) and deduplicated extensions by name inSchema, so an explicitly passed extension (e.g.new Link([...])) replaces the bundled one instead of being rendered twice. Updated the README example. The generated regression testtests/Schema/StarterKitTest.phpis missing from the published patch, so regression coverage remains incomplete. Note: the test suite was NOT executed - no PHP runtime or Composer dependencies are available in this environment.