Added duplicate field check and Google Sheet protections check. Creat… - #16
Open
bdgregg wants to merge 1 commit into
Open
Added duplicate field check and Google Sheet protections check. Creat…#16bdgregg wants to merge 1 commit into
bdgregg wants to merge 1 commit into
Conversation
…ed a separate script to check a Google Sheet for protections that hinder updating by the service account.
ctgraham
reviewed
Jul 31, 2026
ctgraham
left a comment
ctgraham
left a comment
Member
There was a problem hiding this comment.
For Google Sheet checks, the standalone tool feels very duplicative to the added function in scan-batch-dir. It adds in additional human-readable description, but this could also be done by a common library, or by the scan-batch-dir calling the standalone tool and using machine readable outputs (e.g. exitcodes).
This isn't a request for changes necessarily, but rather a reminder to keep things DRY as a priority.
The duplicated column code is straightforward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed a separate script to check a Google Sheet for protections that hinder updating by the service account.