Repository navigation
test(v7): preserve explicit Unix epoch timestamp - #990
Merged
Merged
Conversation
broofa
enabled auto-merge (squash)
October 23, 2026 03:47
broofa
disabled auto-merge
October 23, 2026 03:47
broofa
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this test matters
A truthiness fallback would replace the explicitly requested Unix epoch with the current time. The new v7 assertion catches that timestamp substitution in the first 48 bits.
Supertest audit method
I used the Supertest test-audit skill to probe whether the existing suite would catch a plausible violation of this contract. The regression was applied only in an isolated worktree. The regression proof records three executed states: the existing tests pass with that regression, the new assertion fails against the same regression, and the new test passes with the original production code restored. The published diff adds tests only.
Change and verification
Adds a regression test for the explicit
msecs: 0option in UUID v7. The expected UUID carries the Unix epoch timestamp in its first 48 bits.Proof: changing
msecs ??= Date.now()tomsecs ||= Date.now()leaves all 83 existing tests passing, but makes this new assertion fail because the generated UUID contains the current timestamp. With production code restored, all 84 tests pass.Verified with
npm test,npm run test:node,npm run lint,npx tsc --noEmit -p tsconfig.json, andgit diff --check. This PR changes tests only.Repository guidance
CONTRIBUTING.mdasks fornpm test && npm run test:node; both passed. The PR template requests benchmarks for considerable changes; this test-only change has no runtime path or performance change.