Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
JsonScanner.scancontinues to return every matching occurrence. It cannot choose one duplicate-key value without changing its low-level matching semantics.JsonScanner.parsenow followsJSON.parseobject behavior: for repeated keys, the last source occurrence wins.ANY_KEY, therefore parse the same destination only once.JsonScanner.parse. The block receives the selected JSON fragment plusquirks_modeandsymbolize_names; this permits callers to opt into parser-specific behavior such asallow_duplicate_key: true.Documentation and tests
scanmatches or use.last.allow_duplicate_keyexample.Verification
This is deliberately a draft while the implementation and API are reviewed.