Skip to content

GitHub: Support SSH signing key endpoints - #347

Open
SamyPesse wants to merge 1 commit into
vercel-labs:mainfrom
SamyPesse:codex/github-ssh-signing-keys
Open

SamyPesse wants to merge 1 commit into
vercel-labs:mainfrom
SamyPesse:codex/github-ssh-signing-keys

Conversation

@SamyPesse

Copy link
Copy Markdown

Why

Applications that import GitHub SSH signing keys cannot exercise that integration against the emulator because the signing-key endpoints are missing.

Decisions

  • Add authenticated create/list/get/delete and public paginated user listings for SSH signing keys, stored independently of authentication keys.
  • Parse uploaded Ed25519, RSA and NIST ECDSA public keys with a WebCrypto-based parser. Reject private or invalid material, duplicate key fingerprints, and access to another user's authenticated key resources.
  • Document the supported endpoints in the README, GitHub skill, docs site and CLI help. SSH authentication keys, certificates, hardware security-key formats and OAuth scope enforcement remain outside this subset.

Validation: all 114 GitHub tests pass, including SSH key lifecycle, pagination, ownership, duplicate comments, and private-key rejection. GitHub typecheck and build pass; GitHub source and CLI help lint pass with existing warnings. Changed-source formatting passes.

This extracts the SSH signing-key work from #265 into an independent PR based on upstream main.

@vercel

vercel Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@SamyPesse is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​peculiar/​ssh@​3.0.08010010094100

View full report

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant