Repository navigation
Conversation
- Pin @rnx-kit/fork-sync to exact 0.6.0 (0.6.1 is not on the approved feed). - sync.ts: pass the repository root to fork-sync via -C. - sync-config.json: use snapshot fetch mode and keep local deletions. - dev.ps1: require Node 24+ before restoring fork-sync and .ado/scripts, and restore them with lock-aware npm ci --ignore-scripts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Import facebook/hermes static_h at 26fbb82 with fork-sync 0.6.0 (snapshot mode, local deletions kept) and integrate it with the Windows fork: - hermes.dll producers and internal JSI clients build at JSI 22; public JSI headers still fall back to 21; JSI_UNSTABLE stays ON. - Keep fork Node-API, WinGlob Unicode and Intl providers; upstream NAPI stays off on Windows; remove the deleted upstream ICU backend. - Keep MicrotaskQueue=false support (RNW bridge mode) over upstream d800198, with tests for both queue modes. - Keep the HermesExport.h CREATE_SHARED_LIBRARY guard; hermes.dll exports C names only. - Suppress CRT/WER dialogs in Node-API test mains and Static Hermes programs; bound Node-API child-process tests with a timeout. - Fix shermes CRT flag selection for clang; add Proxy array JSI test. npm/Yarn lock reconciliation for imported packages follows in a separate commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Make external/node-api-cts/.npmrc registry-free like the other committed .npmrc files, add its package-lock.json (no resolved URLs), and update the hermes-parser and flow-bundler yarn.lock files lock-only for the imported manifest changes. Locks were resolved anonymously through PackageFeedProxy. No auth, security resolutions kept, no downgrades. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- README: add the grouped JSI 22 row with static_h hashes, keep main hashes, note 606a424 (main) and b10cafd (static_h) are the same JSI 21, and map React Native 0.80=19, 0.81=20, 0.82-0.85=21, 0.86+/main=22. hermes.dll builds at 22; public headers fall back to 21; RNW uses 21 over the C API. - Add default-built, unlinked compile-only objects that compile the public JSI headers, jsi.cpp and decorators at JSI 20 and at the header fallback (21). - Fix stale jsi.h comments about the default version and header name. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Check every built hermes.dll copy with dumpbin /nologo /exports from build.js so `dev build` and the ADO build step share one gate. Fail on tool errors, empty or unparseable output, C++ (MSVC/Itanium) names, DATA, ordinal-only and forwarded exports, missing required names, and unknown C names (add them to hermes-exports.txt). hoost_* exports are optional only on ARM64EC. Add unit tests and run them in the ADO pipeline next to the npm source lint tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Upstream static_h moved destruction of JSI HostObject, HostFunction and NativeState owners to an always-on finalizer worker thread. hermes-windows keeps today's behavior: when RuntimeConfig::FinalizerThreadRunner is unset (the jsr/hermes.dll path), owners are destroyed inline in their VM finalizer and no worker thread is created. An explicitly supplied runner keeps the upstream worker. Tests cover every owner kind in both modes. NodeApi child-process tests now run each child in a job object (KILL_ON_JOB_CLOSE) so a timeout also ends grandchildren, and the test-host copies of hermes.dll are refreshed whenever the DLL changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tion - APITests: query the Hades background thread only in debug builds, so release builds with handle sanitization compile; that configuration checks exactly-once finalization. - JSI tests: use the checked asArray conversion for the revoked Proxy case, because getArray validates only in debug builds. - NodeApi tests: match the exact abort status and output of the debug and release CRT, and treat a reused protected PID as gone. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Suppress CRT/WER crash dialogs in hermes_rt, hdb, and hbc-diff, which run lit and test262 Intl tests. - Merge adjacent JSI_VERSION >= 22 guards in decorator.h, jsi.h, and jsi-inl.h; preprocessed output is unchanged at JSI 20, 21, and 22. - Drop the custom-runner cases from OwnerFinalizationTest; the FinalizerThreadRunner test keeps that coverage. - Set up the VS environment once per build for the export check. - Restore executable bits on three imported scripts, fix the NodeApi spelling in .syncignore, and document the export check and the fork behaviors to keep on every sync in AGENTS.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The imported bootstrap loop in tools/hermes-parser/js/scripts/build.sh called bare `yarn`, bypassing the repository's pinned Yarn 4 that microsoft#378 routed every other call in this script through. Use run_yarn there as well. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary test of GitHub diff limits for microsoft#408. Do not merge; will be closed.