Skip to content

Only send finish message if chatops enabled. - #284

Merged
dhollinger merged 1 commit into
voxpupuli:masterfrom
markeganfuller:finish_message_disable
Oct 26, 2026
Merged

dhollinger merged 1 commit into
voxpupuli:masterfrom
markeganfuller:finish_message_disable

Conversation

@markeganfuller

Copy link
Copy Markdown
Contributor

Previously the message would be sent if chatops was configured but disabled e.g.

chatops:
  enabled: false
  service: slack
  channel: "#channel"
  user: puppet
  auth_token: xxxxx

marcusdots
marcusdots previously approved these changes Oct 19, 2026

@marcusdots marcusdots left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markeganfuller

Copy link
Copy Markdown
Contributor Author

Sorry I just fixed the conflicts apparently my master was stuck on an old fork 🙈

@marcusdots marcusdots left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval is still valid.

@dhollinger
dhollinger merged commit fd6e4e1 into voxpupuli:master Oct 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants