Migrate legacy treesitter captures and drop discontinued plugin themes - #46
Merged
Merged
Conversation
nvim-treesitter dropped the legacy capture names in the 2024-01 upstream alignment; current parsers only emit the new ones, so the old groups have been dead weight on modern setups. @string.regex, @parameter, and @include become @string.regexp, @variable.parameter, and @keyword.import with identical colors. The five @text.* groups are deleted outright — their @markup.* successors were already defined, so they were duplicate legacy names, not renames. On nvim 0.9.x the old names fall back to core default links; only 0.10+ pinned to a pre-rename nvim-treesitter loses styling for them. The nvim-0.8.0 block now carries 39 groups, so the writer_output threshold moves from >= 40 to >= 35. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YFHQwnUznbUjeJepbqUsj1
Removes highlight groups for plugins whose upstreams have formally ended: null-ls (repository deleted; successor none-ls), dressing.nvim (archived; successor snacks.input), defx.nvim with defx-icons/defx-git (development stopped in favor of ddu.vim), and vimfiler (same). The defx removal also retires the 16-color defxicon palette and the generated g:defx_icons_* dictionaries. easymotion and vim-clap stay: neither has a discontinuation notice and vim-clap is actively developed. FloatTitle survives the dressing section removal — it is a core nvim highlight group (0.9+) that was merely filed under the dressing comment; it now lives next to the other float groups, unchanged. Affected plugins fall back to default colors; nothing breaks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YFHQwnUznbUjeJepbqUsj1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Namespace cleanup for the highlight definitions — no color value changes on any surviving group (verified byte-for-byte by the golden test and a sorted diff against the base commit).
Treesitter captures: nvim-treesitter dropped the legacy capture names in its 2024-01 upstream alignment, so current parsers never emit them.
@string.regex,@parameter, and@includeare renamed to@string.regexp,@variable.parameter, and@keyword.importwith identical colors. The five@text.*groups are deleted outright — their@markup.*successors were already defined, so they were duplicate legacy names. On nvim 0.9.x the old names fall back to core default links; on current Neovim they were simply dead definitions (nvim_get_hlreturns nothing for them).Discontinued plugin themes: removes highlight groups for plugins whose upstreams have formally ended — null-ls (repository deleted; successor none-ls), dressing.nvim (archived; successor snacks.input), defx.nvim with defx-icons/defx-git (development stopped in favor of ddu.vim), and vimfiler. The defx removal also retires the 16-color
defxicon*palette and the generatedg:defx_icons_*dictionaries. Affected setups fall back to default colors; nothing breaks.easymotion and vim-clap are intentionally kept — neither has a discontinuation notice and vim-clap is actively developed.
FloatTitle, which was filed under the dressing.nvim comment but is a core nvim highlight group (0.9+), survives unchanged and now lives next to the other float groups.Net: −143 lines.
Test plan
just check(fmt + clippy-D warnings+ all 14 tests, golden test included)just fresh-check— regenerated outputs match the committed filescolors/dogrun.vimare the three renamed groups with identicalguifg/ctermfgvaluesReferences
🤖 Generated with Claude Code
https://claude.ai/code/session_01YFHQwnUznbUjeJepbqUsj1