Skip to content

Prevent zsh correction prompts from blocking agent commands - #15203

Open
bivo wants to merge 1 commit into
warpdotdev:masterfrom
bivo:bivo/fix-agent-zsh-correction
Open

Prevent zsh correction prompts from blocking agent commands#15203
bivo wants to merge 1 commit into
warpdotdev:masterfrom
bivo:bivo/fix-agent-zsh-correction

Conversation

@bivo

@bivo bivo commented Aug 16, 2026

Copy link
Copy Markdown

Use zsh-specific command decoration for agent-requested commands while preserving pager handling and existing execution guards.

Description

Fixes an Agent Mode regression in interactive zsh sessions with correction enabled.

When the agent runs a mistyped command (for example zef README.md), zsh can prompt:

zsh: correct 'zef' to 'zed' [nyae]?

That prompt blocks autonomous agent execution. This PR suppresses zsh correction only for agent-requested commands by decorating those commands with nocorrect, while preserving existing command execution behavior and pager handling.

Linked Issue

Closes #13613

Testing

Manually tested with ./script/run.
Reproduced baseline behavior in stable build:

zsh: correct 'zef' to 'zed' [nyae]?

appears and can block flow

Verified fixed behavior in local build:
◦ agent-requested mistyped command does not block on correction prompt
◦ command fails normally (e.g. command not found)
Verified manual user-typed commands still keep normal zsh correction behavior

Also auto-tests are updated.

Screenshots / Videos

How it works currently in production build:
production_build

And how it works after fix in this PR:
local_build_with_fix

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot

cla-bot Bot commented Aug 16, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @bivo on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Aug 16, 2026
@bivo

bivo commented Aug 16, 2026

Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Aug 16, 2026
@cla-bot

cla-bot Bot commented Aug 16, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

Use zsh-specific command decoration for agent-requested commands while preserving pager handling and existing execution guards.

Co-Authored-By: Oz <oz-agent@warp.dev>
@bivo
bivo force-pushed the bivo/fix-agent-zsh-correction branch from cfa6ea0 to b060f48 Compare August 16, 2026 15:52
@bivo
bivo marked this pull request as ready for review August 16, 2026 15:53
@oz-for-oss

oz-for-oss Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

@bivo

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bivo

Every PR must be linked to a same-repo issue before Oz can review it.

Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent-driven zsh commands can block on spelling-correction prompts when correction is enabled

1 participant