Repository navigation
Conversation
Signed-off-by: Karl Matthias <karl.matthias@mechanical-orchard.com>
relistan
marked this pull request as ready for review
September 16, 2026 16:47
autodidaddict
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Currently,
nkeysimports thesignatorycrate just to usesignature::Error. This unnecessarily drags inpkcs8andderas dependencies. Security scanners often flagder0.7.10 because of a quadratic decoding issue, and we can't easily upgrade it because of thesignatorydependency chain.This PR fixes the issue by replacing
signatorywith a direct dependency onsignature2.x (with thestdfeature enabled). We still get the exact samesignature::Errortype, so the public API, key parsing, and signing behavior remain exactly the same.Related Issues
Related to #56. This PR is specifically focused on dropping the unused
signatorydependency.Release Information
Next patch release.
Consumer Impact
Projects using this crate will no longer pull in
signatory,pkcs8, order. No code changes are required for users. Downstream projects carrying a vendored patch for thederissue can drop it once this is released.Testing
Unit Test(s)
All existing unit tests pass, including those for signing, key encoding, and invalid signatures. No tests needed to be changed.
Acceptance or Integration
The CLI target builds successfully and documentation examples pass.
Manual Verification
cargo test --all-features: 32 unit tests and 1 doctest passed.cargo fmt --all -- --check: passed.cargo clippy --all-features --tests -- -D warnings: passed.cargo tree --all-features --locked: confirmed thatsignatory,pkcs8, andderare no longer in the dependency tree.