feat: make license file optional and support cloudready quickstart jar naming - #29
Merged
tobias-richter merged 2 commits intoSep 14, 2026
Conversation
…r naming - aem_cms_license_file can be set to false to skip installing a license file - creates check for quickstart unpack now globs to also match the cq-quickstart-cloudready-<version>-standalone-quickstart.jar naming variant
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Update in-place upgrade parsing for CloudReady names and correct the README grammar.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Makes the AEM license optional and supports CloudReady quickstart JAR naming.
Changes:
- Skips license installation when configured as
false. - Expands quickstart detection for CloudReady JAR names.
- Documents the optional license behavior.
File summaries
| File | Summary |
|---|---|
tasks/main.yml |
Adds conditional license installation and CloudReady JAR matching. The in-place upgrade logic still needs to normalize the cloudready- prefix (moderate, 1 vote). |
README.md |
Documents optional licensing; fix the noted grammar issue (nit, 3 votes). |
defaults/main.yml |
Clarifies that the license variable supports false. |
Review details
Suppressed comments (1)
tasks/main.yml:70
- This glob makes the unpack task idempotent for a cloudready jar, but the existing in-place-upgrade path still parses that filename with
tasks/in_place_upgrade.yml:7, producingcloudready-<version>instead of the version key expected byaem_cms_in_place_upgrade_paths. Upgrading an installation that already has acq-quickstart-cloudready-<version>-standalone-quickstart.jarcan therefore fail during version comparison or path lookup; normalize the optionalcloudready-prefix in the upgrade logic as part of this naming support.
creates: "{{ aem_cms_home }}/crx-quickstart/app/cq-quickstart-*{{ aem_cms_version }}-standalone-quickstart.jar"
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…version Addresses Copilot review feedback on PR #29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aem_cms_license_filecan be set tofalseto skip installing a license filecreatescheck for quickstart unpack now globs to also match thecq-quickstart-cloudready-<version>-standalone-quickstart.jarnaming variant