Repository navigation
Conversation
dbrant
requested review from
Williamrai,
cooltey and
voyagerfan
as code owners
September 10, 2026 19:02
Williamrai
approved these changes
Nov 6, 2026
Williamrai
left a comment
Williamrai
left a comment
Collaborator
There was a problem hiding this comment.
I did not find any issues while testing. I first installed the release build before obfuscation and used features like widgets, games, Places, and notifications. I then updated the app to the obfuscated release build and tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches to the new way (as of AGP 9.3) of enabling optimization of the app package with R8.
This also enables obfuscation (or rather removes disabling of obfuscation) from the release build. This will need to be tested very thoroughly, particularly in places where reflection might be happening (dependencies that use Gson? etc).
https://phabricator.wikimedia.org/T436882