Conversation
listAppsAndCollaborators() (formerly listAllAppsAndCollaboratorApps()) resolved each team collaborator's profile via usersAPI.getUsers to tell apps apart from humans, but then silently dropped every non-app profile instead of surfacing it. Human collaborators (e.g. external users with team permissions who aren't full team members) never appeared anywhere in the app. - SearchTask: split resolved collaborator profiles by `.type` instead of dropping non-apps; broaden the guard so the fetch also runs for empty-query `.contacts`/`.teamMembers` requests (previously `.apps` only), gating which bucket(s) get merged by the requested options so behavior for `.apps`-only and non-empty-query searches is unchanged. - SearchResult: add a `collaborators` bucket and a `union(withCollaboratorsResult:)` merge function that dedupes by remoteIdentifier against contacts/teamMembers/collaborators already present. - SearchResultsViewController: fold `collaborators` into the same contacts/team-members section as regular contacts, never through the apps-specific section controller. - Tests: extend the apps/collaborators SearchTask test with a non-app collaborator fixture, add coverage for the new collaborators bucket and its dedup against existing team members, and add a regression test asserting the `.create` (new-conversation) flow never shows the apps group selector. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…rators subroutes. don't use apps that appear as team members anymore. show apps in contact picker and in add participant picker.
ikotarac
changed the title
Contributor
Test Results3 097 tests 3 070 ✅ 3m 50s ⏱️ Results for commit 9f6d367. Summary: workflow run #34847869762 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
This is a diagram of how different endpoints return different schemas, and how they all map to apps and people (regular users) in the end.
Testing
I have tested it on staging backend using a testing teams with both own apps and external apps added.
External apps flow is unlocked on dev environment of teams: wire-teams-dev.zinfra.io (uses staging version of backend and dev version of wire teams).
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-09-11.at.11.24.06.mov
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: