Skip to content

Fixes for X.509 extension values, EKU OIDs, setVerify registration - #437

Merged
rlm2002 merged 3 commits into
wolfSSL:masterfrom
cconlon:fenrirOct16
Oct 19, 2026
Merged

rlm2002 merged 3 commits into
wolfSSL:masterfrom
cconlon:fenrirOct16

Conversation

@cconlon

@cconlon cconlon commented Oct 16, 2026

Copy link
Copy Markdown
Member

This PR includes 3 Fenrir fixes:

  • F-15695: Return the extension value from X509_get_extension() instead of its OID. WolfSSLX509.getExtensionValue() now returns DER encoding matching the JDK.

  • F-15741: Always register the native verify callback in setVerify(), and throw if the Java callback cannot be stored.

  • F-15696: Return every EKU OID in certificate order from getExtendedKeyUsage(), including OIDs wolfSSL has no flag for, and throw if the EKU cannot be decoded.

@cconlon cconlon self-assigned this Oct 16, 2026
Copilot AI balanced review requested due to automatic review settings October 16, 2026 23:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #437

Scan targets checked: wolfssljni-src, wolfssljni-bugs
Not reviewed (no scan target covers them): examples/certs/test/eku-bad-oid-cert.pem, examples/certs/test/eku-large-arc-cert.pem, examples/certs/test/eku-unknown-cert.pem, examples/certs/test/eku-unknown-mixed-cert.pem, examples/certs/update-certs.sh
Coverage: 4 of 8 in-scope changed file(s) opened by the reviewer; not opened: src/java/com/wolfssl/WolfSSLSession.java, src/java/com/wolfssl/provider/jsse/WolfSSLEngineHelper.java, src/test/com/wolfssl/provider/jsse/test/WolfSSLX509Test.java, src/test/com/wolfssl/test/WolfSSLCertificateTest.java

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

@cconlon cconlon assigned rlm2002 and unassigned cconlon Oct 16, 2026
@rlm2002
rlm2002 merged commit 2c60d2f into wolfSSL:master Oct 19, 2026
109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants