fix: drop unused vitest>vite pnpm overrides - #73
Merged
Conversation
vitest@4.1.11's peer range still resolves vite to 6.4.3 without pinning it via pnpm-workspace.yaml overrides, so the override is redundant. Confirmed the resolved version is unchanged after regenerating the lockfile.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A — small maintenance fix, no tracking issue.
🧭 Context
pnpm-workspace.yamlpinnedvitest>viteand@vitest/mocker>viteto6.4.3viaoverrides, with a comment explaining Vite 8/oxc doesn't support the experimental decorator transform vitest needs. That pin is redundant:vitest@4.1.11's own peer range already resolvesviteto6.4.3without any override.📚 Description
overridesblock (and its comment) frompnpm-workspace.yaml.pnpm-lock.yamlviapnpm installand confirmedvitestill resolves to6.4.3everywhere.Key changes
pnpm-workspace.yamlvitest>vite/@vitest/mocker>viteoverridespnpm-lock.yamlNote: open Renovate PRs #28 (
@vitest/mocker>vite→ v8) and #29 (vitest>vite→ v8) target this override — they'll need re-evaluating once this merges, since bumping pastvite@6still breaks the decorator transform per the removed comment.Type of Change
Pre-flight Checklist
pnpm changeset(orpnpm changeset add --emptyif no release is needed). See .changeset/README.md. — not applicable, no publishable package changed.Confidence Score: 4/5
This change is non-blocking for the committed lockfile, but it is not safe for future clean dependency resolution until the Vite 6 constraint is restored.
One verified non-security P2 finding is present, and there are no P0 or P1 findings.
Files Needing Attention: pnpm-workspace.yaml
What T-Rex did
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix: drop unused vitest>vite pnpm overri..." | Re-trigger Greptile