Repository navigation
fix(install): copy the kickstart pre-install log from the installer - #8006
Open
viniciusferrao wants to merge 3 commits into
Open
viniciusferrao wants to merge 3 commits into
viniciusferrao wants to merge 3 commits into
Conversation
The riscv64 profile test runs every rendered %post block as if it ran in the installed system. Anaconda runs a --nochroot block in the installer, with the installed system at /mnt/sysimage, so give such a block that view.
The EL8 and later kickstart templates append /tmp/pre-install.log to /var/log/xcat/xcat.log in the chroot %post. Anaconda runs that block in the installed system, whose /tmp does not hold the installer's log, so the %pre output, such as the install disk and the partition layout, never reaches the node's xcat.log. Copy the log in a %post --nochroot block before the main %post, from the installer's /tmp to the installed system at /mnt/sysimage. The EL6 and EL7 templates use %include for this and are unchanged.
Run the rendered %post --nochroot blocks of each kickstart template whose %pre writes /tmp/pre-install.log the way anaconda runs them: in the installer, with its own /tmp and the installed system at /mnt/sysimage. The riscv64 profile test now keeps the installer's /tmp out of the installed root too. Both fail on the old templates, whose chroot %post reads a /tmp that does not hold the log. Run the new test in the profile artifact job.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EL8 and later kickstart templates copy
/tmp/pre-install.loginto the node's/var/log/xcat/xcat.logfrom the chroot%post. Anaconda runs that block in the installed system, whose/tmpdoes not have the log, so the%preoutput, such as the install disk and the partition layout, never reachesxcat.log. The%postlog of such an install showscat: /tmp/pre-install.log: No such file or directory.The templates now copy the log in a
%post --nochrootblock before the main%post, from the installer's/tmpto the installed system at/mnt/sysimage. This covers the rhels8, rhels9, rhels10, centos8, openEuler and EL10 riscv64 templates, and the templates that link to them.Thanks-to: SpacemiT (riscv64 test hardware)