Repository navigation
fix(install): stop nodeset when a template has no root password - #8007
Open
viniciusferrao wants to merge 2 commits into
Open
viniciusferrao wants to merge 2 commits into
viniciusferrao wants to merge 2 commits into
Conversation
A #CRYPT# template entry rendered as an empty string when the passwd table had no row for its key. An EL kickstart then held a bare "rootpw --iscrypted", and anaconda stopped with "A single argument is expected for the rootpw command". nodeset reported no error. nodeset now reports the missing passwd row and writes no boot configuration for the node, as it does for a missing #TABLE# field. #CRYPTORLOCKED# still renders a locked password.
The EL10 kickstart must not render without the passwd row, and must carry the hash of the configured password when the row exists. The Ubuntu autoinstall must still lock a password that has no row. The first case fails with the earlier code, which rendered an empty rootpw.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
#CRYPT#template entry renders as an empty string when thepasswdtable has no row for its key. An EL kickstart then holds a barerootpw --iscrypted, and anaconda stops with "A single argument is expected for the rootpw command".nodesetreports no error.nodesetnow reports the missingpasswdrow and writes no boot configuration for the node, as it does for a missing#TABLE#field.#CRYPTORLOCKED#still renders a locked password.