Repository navigation
fix(netboot): keep EL10 diskless nodes from DHCP on every port - #8008
Open
viniciusferrao wants to merge 4 commits into
Open
viniciusferrao wants to merge 4 commits into
viniciusferrao wants to merge 4 commits into
Conversation
genimage wrote an ifcfg file for each interface that otherifce or genimage -r names. EL10 reads no ifcfg files, and its images have no network-scripts directory. Such an interface got DHCP only from the profile that NetworkManager makes for any port without one. genimage now writes a NetworkManager keyfile with DHCP for each of these interfaces on EL10 and later. A rebuild replaces the keyfiles of the earlier build. Older releases still get the same ifcfg files.
An EL10 image must get a DHCP keyfile for each requested interface, also when it has a network-scripts directory. Only root can read the keyfiles, and the interface of the initial ramdisk gets none. A rebuild must drop the keyfile of an interface that is no longer requested and keep other profiles. An EL9 image must keep its ifcfg files.
NetworkManager in an EL10 diskless image made a DHCP profile for every Ethernet port without one. A port with a link but no DHCP server kept NetworkManager-wait-online from finishing, so the node booted degraded. Diskful nodes are not affected, because anaconda writes a profile for every port. genimage now sets no-auto-default=* in the NetworkManager configuration of EL10 images. The boot interface keeps the profile from the initial ramdisk. The other interfaces get only the profiles that the image or the xCAT network configuration gives them.
An EL10 image must turn off the automatic DHCP profiles. An EL9 image must keep the NetworkManager defaults, and an image without NetworkManager must get no NetworkManager configuration.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkManager in an EL10 diskless image makes a DHCP profile for every Ethernet port without one. A port with a link but no DHCP server keeps
NetworkManager-wait-onlinefrom finishing, so the node bootsdegraded. Diskful nodes are not affected, because anaconda writes a profile for every port.genimagenow setsno-auto-default=*in the NetworkManager configuration of EL10 images. The boot interface keeps the profile from the initial ramdisk.The interfaces that
otherifcenames got DHCP only from those automatic profiles, because EL10 reads no ifcfg files.genimagenow writes NetworkManager keyfiles for them on EL10, and a rebuild replaces them.Thanks-to: SpacemiT (riscv64 test hardware)