Repository navigation
fix: pass createCommitOnBranch files via graphql --input - #24
Merged
Merged
Conversation
gh -F additions=JSON does not send a [FileAddition!] list, so the packaging-bump mutation failed with Expected to be a key-value object. Build the query and fileChanges with jq and post them with gh api graphql --input. Check the checked-out tag SHA, not GITHUB_SHA, so workflow_dispatch from a non-main ref still validates the tag.
upload-artifact@v4 and download-artifact@v4 still run on Node 20, which GitHub hosted runners now warn about. v6/v7 default to Node 24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Dry-run on
chore/packaging-dry-run(--skip=publish, tagv0.6.0) showedgh -F additions=...does not send a GraphQL[FileAddition!]list.This posts the mutation with
gh api graphql --inputsofileChanges.additions/deletionsare real JSON arrays. Also validate the checked-out tag SHA (notGITHUB_SHA) soworkflow_dispatchfrom a non-main ref still checks the tag.Throwaway dry-run passed after enabling Actions to create PRs: https://github.com/xeaser/squad-opencode/actions/runs/32942440031
Opened and closed dry-run pin PR #23 (verified
github-actions[bot]commit). Latest release remainsv0.6.0.How to test
release.ymldispatch with--skip=publish+tag=v0.6.0go test ./internal/versionChecklist