Fail the macOS build when the D runtime lookup fails

[ap-1]

If find_runtime_libraries can't find phobos/druntime it prints an error and exits 1, but since it's called inside $(...) as an argument to libtool, set -e doesn't catch it.

Instead, the build keeps going and you end up with a libxadibase.a that doesn't have the D runtime in it, which only shows up later as undefined symbol errors when linking. We can assign it to a variable first to make the build stop there instead.

I ran into this packaging xadi for nixpkgs, where the lookup failed and the build still succeeded.

Summary by CodeRabbit

• Bug Fixes
  • Fixed a macOS build issue where a failed runtime library lookup could allow linking to continue with missing libraries.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1dcfdf00-0f18-4a82-badc-e466113e6d66

📥 Commits

Reviewing files that changed from the base of the PR and between 5b1b490 and 17e9966.

📒 Files selected for processing (1)

• macOS/build.sh

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The macOS build script now resolves runtime libraries before calling libtool. If the lookup fails, set -e stops the script at the assignment.

Changes

Runtime library build

Layer / File(s)	Summary
Resolve runtime libraries macOS/build.sh	build_arch captures the runtime-library paths before invoking libtool and passes them to the archive command. With set -e, a failed lookup stops the script at the assignment.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 17e99

The runtime lookup now occurs before archive creation, and callers do not suppress failure handling.

Architecture Summary

Architecture risk: 🔵 Low · up to 17e99

The change affects 1 system.

Changed systems: macOS

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — macOS (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in macOS/build.sh: build_arch adds a local runtime_libraries variable for the resolved runtime-library paths.
• observed — Modified behavior in macOS/build.sh: build_arch now resolves runtime libraries before calling libtool and supplies the captured paths to the archive command. A failed lookup now terminates the script at the assignment under set -e; previously the lookup ran inside libtool’s arguments.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: making the macOS build fail when the D runtime lookup fails.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

_{Comment @coderabbitai help to get the list of available commands.}

[kabiroberai]

thanks!