Repository navigation
fix(lazy install): keep production focused installs production - #367
Conversation
After `yarn workspaces focus <ws> --production`, the first command run from that workspace started a full install. The lazy install check included devDependencies when computing the workspaces the current one needs, so workspaces only reachable through devDependencies looked missing. The install state now records whether the install was a production one. If it was, the check only follows production dependencies.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Production mode dropped on lazy reinstall
- Modified lazy_install to respect the stored production flag when calling run_install and when extending focused install roots, preventing production mode from being cleared on implicit reinstalls.
Or push these changes by commenting:
@cursor push 907129ace1
Preview (907129ace1)
diff --git a/packages/zpm/src/project.rs b/packages/zpm/src/project.rs
--- a/packages/zpm/src/project.rs
+++ b/packages/zpm/src/project.rs
@@ -1526,7 +1526,7 @@
.chain(required_workspaces.iter())
.cloned();
- Some(self.workspace_dependency_closure(roots, true)?)
+ Some(self.workspace_dependency_closure(roots, include_dev_dependencies)?)
} else {
None
}
@@ -1536,11 +1536,14 @@
None
};
+ let prune_dev_dependencies
+ = self.install_state.as_ref().is_some_and(|install_state| install_state.production);
+
let install = self.run_install(RunInstallOptions {
check_checksums: false,
check_resolutions: false,
enforced_resolutions: BTreeMap::new(),
- prune_dev_dependencies: false,
+ prune_dev_dependencies,
refresh_lockfile: false,
silent_or_error: true,
mode: None,You can send follow-ups to the cloud agent here.
✅ Deploy Preview for yarn-v6 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
⏱️ Benchmark Resultsgatsby install-full-cold
📊 Raw benchmark data (gatsby install-full-cold)Base times: 4.312s, 4.365s, 4.329s, 4.329s, 4.278s, 4.253s, 4.374s, 4.272s, 4.429s, 4.274s, 4.306s, 4.350s, 4.400s, 4.355s, 4.267s, 4.322s, 4.319s, 4.307s, 4.461s, 4.465s, 4.443s, 4.440s, 4.394s, 4.364s, 4.416s, 4.375s, 4.398s, 4.392s, 4.289s, 4.292s Head times: 4.404s, 4.437s, 4.311s, 4.377s, 4.437s, 4.373s, 4.385s, 4.440s, 4.419s, 4.401s, 4.362s, 4.451s, 4.484s, 4.370s, 4.288s, 4.412s, 4.479s, 4.334s, 4.457s, 4.417s, 4.388s, 4.484s, 4.362s, 4.415s, 4.360s, 4.484s, 4.383s, 4.425s, 4.417s, 4.386s gatsby install-cache-only
📊 Raw benchmark data (gatsby install-cache-only)Base times: 1.338s, 1.322s, 1.334s, 1.355s, 1.328s, 1.352s, 1.331s, 1.325s, 1.320s, 1.322s, 1.360s, 1.331s, 1.323s, 1.316s, 1.320s, 1.330s, 1.317s, 1.319s, 1.357s, 1.333s, 1.332s, 1.315s, 1.336s, 1.343s, 1.347s, 1.322s, 1.332s, 1.334s, 1.332s, 1.337s Head times: 1.300s, 1.322s, 1.337s, 1.334s, 1.339s, 1.338s, 1.325s, 1.348s, 1.344s, 1.330s, 1.334s, 1.336s, 1.327s, 1.322s, 1.339s, 1.342s, 1.352s, 1.328s, 1.514s, 1.317s, 1.302s, 1.305s, 1.304s, 1.318s, 1.319s, 1.315s, 1.320s, 1.320s, 1.312s, 1.311s gatsby install-cache-and-lock (warm, with lockfile)
📊 Raw benchmark data (gatsby install-cache-and-lock (warm, with lockfile))Base times: 0.368s, 0.371s, 0.368s, 0.368s, 0.370s, 0.370s, 0.370s, 0.373s, 0.370s, 0.368s, 0.369s, 0.369s, 0.367s, 0.364s, 0.364s, 0.365s, 0.366s, 0.369s, 0.368s, 0.380s, 0.377s, 0.381s, 0.378s, 0.379s, 0.375s, 0.376s, 0.380s, 0.395s, 0.369s, 0.372s Head times: 0.373s, 0.372s, 0.368s, 0.371s, 0.367s, 0.370s, 0.373s, 0.497s, 0.372s, 0.370s, 0.367s, 0.374s, 0.380s, 0.375s, 0.373s, 0.368s, 0.374s, 0.374s, 0.390s, 0.376s, 0.372s, 0.368s, 0.367s, 0.369s, 0.372s, 0.372s, 0.372s, 0.372s, 0.370s, 0.380s |
When a command outside the focused workspaces extended a production install, the lazy install followed devDependencies and ran without pruning them, putting them back in the tree and clearing the flag. Both now follow the production setting of the previous install.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Full lazy install strips dests
- Changed prune_dev_dependencies to only be true when both production mode AND install_roots is Some (focused install), preventing lockfile corruption when unfocused installs rewrite the lockfile.
Or push these changes by commenting:
@cursor push 7c0c72135a
Preview (7c0c72135a)
diff --git a/packages/zpm/src/project.rs b/packages/zpm/src/project.rs
--- a/packages/zpm/src/project.rs
+++ b/packages/zpm/src/project.rs
@@ -1542,7 +1542,7 @@
check_checksums: false,
check_resolutions: false,
enforced_resolutions: BTreeMap::new(),
- prune_dev_dependencies: production,
+ prune_dev_dependencies: production && install_roots.is_some(),
refresh_lockfile: false,
silent_or_error: true,
mode: None,You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit a8f1f57. Configure here.
…duction # Conflicts: # tests/acceptance-tests/pkg-tests-specs/sources/features/lazyInstalls.test.ts
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: e4c770f7-173b-4f60-9fa4-1f30e1944c4f) |
Issue: after
yarn workspaces focus <ws> --production, the first command run from that workspace triggered a full install. The lazy install check included devDependencies, so workspaces only reachable through them looked missing.Fix: the install state records whether the install was a production one. If it was, the check only follows production dependencies. Covered by a lazy-install test.
Note
Medium Risk
Changes lazy-install eligibility and focused-install extension behavior for monorepos; incorrect handling could skip needed installs or omit dev deps when users expect a full tree.
Overview
Fixes lazy install treating production
yarn workspaces focus … --productioninstalls like full installs, which could trigger an unnecessary reinstall or pull devDependencies back in when extending coverage.Install state now records a
productionflag (fromprune_dev_dependenciesduring install) and persists it with the rest ofInstallState. Lazy install reads that flag: workspace closure and focused-install extension only follow production/optional deps whenproductionis true, and any triggered install keepsprune_dev_dependenciesaligned so dev deps are not re-added.Acceptance tests cover skipping lazy install after a production focus and keeping dev packages out of
.pnp.cjswhen another workspace extends the tree.Reviewed by Cursor Bugbot for commit 6e89dc5. Bugbot is set up for automated code reviews on this repo. Configure here.