Skip to content

fix(pnpm linker): always link dependencies next to store packages #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 2 commits into from
Oct 13, 2026
Merged

fix(pnpm linker): always link dependencies next to store packages #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bad369
fix(pnpm linker): always link dependencies next to store packages
arcanis Oct 8, 2026
3b7e964
Merge branch 'main' into mael/pnpm-store-links
arcanis Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions packages/zpm/src/linker/pnpm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,12 +449,6 @@ pub async fn link_project_pnpm<'a>(project: &'a Project, install: &'a Install) -
let workspace
= project.try_workspace_by_locator(locator)?;

let physical_package_data = install.package_data.get(&locator.physical_locator())
.unwrap_or_else(|| panic!("Failed to find physical package data for {}", locator.physical_locator().to_print_string()));

let is_local
= matches!(physical_package_data, PackageData::Local {..});

let mut has_explicit_self_dependency
= false;

Expand All @@ -470,16 +464,6 @@ pub async fn link_project_pnpm<'a>(project: &'a Project, install: &'a Install) -

package_map_builder.register_dependency(locator, dep_name, dep_locator)?;

if !is_local && !locator.reference.is_workspace_reference() {
if let Some(hoisted_locator) = hoisted_packages.get(dep_name) {
// If the exact same version is hoisted, skip creating the symlink
// The package will resolve it through the store's shared node_modules
if *hoisted_locator == dep_locator {
continue;
}
}
}

// node_modules/.yarn/store/@types-no-deps-npm-1.0.0-xyz/node_modules/@types/no-deps
let dep_rel_location
= locations_by_package
Expand Down
25 changes: 25 additions & 0 deletions tests/acceptance-tests/pkg-tests-specs/sources/features/pnpm.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,31 @@ describe(`Features`, () => {
),
);

test(
`it should link every dependency next to a store package, even hoisted ones`,
makeTemporaryEnv(
{
dependencies: {
[`one-fixed-dep`]: `1.0.0`,
},
},
{
nodeLinker: `pnpm`,
pnpmHoistPatterns: [`*`],
},
async ({path, run}) => {
await run(`install`);

// Tools that crawl the store (bundlers, type corpora) read a
// package's dependencies from its own node_modules, as pnpm lays
// them out; the hoisted copy isn't a substitute
const store = ppath.join(path, `node_modules/.yarn/store`);
const entry = (await xfs.readdirPromise(store)).find(name => name.startsWith(`one-fixed-dep-`))!;
await expect(xfs.existsPromise(ppath.join(store, entry, `node_modules/no-deps/package.json`))).resolves.toEqual(true);
},
),
);

test(
`pnpmPublicHoistPatterns with wildcard should hoist all transitive dependencies`,
makeTemporaryEnv(
Expand Down
Loading