fix(zarr-metadata): a v2 array's other members are JSON with string keys

[d-v-b]

🤖 AI text below 🤖

A v2 array document's members outside the .zarray definition are tolerated and dropped, since the spec asks readers to ignore them (#4365). But the validator never looked at them, so parse_array_metadata_v2 returned a document with an integer key, or with a set or NaN as a member, typed as ZarrV2ArrayMetadataJSON, where is_array_metadata_v2 said no.

They are now checked as v3 checks its extension fields: every key a string, every member JSON. Being there is still not a problem. The helper that does this serves both versions now, so it is renamed from _validate_extension_fields_v3 to _validate_other_members, and ZarrV2ArrayMetadataJSON declares extra_items=JSONValue, as its pydantic schema already did.

This is one of eight independent PRs from a review of the casts in zarr_metadata.model, each based on main and each passing just check alone, with a test that fails without its fix where there is behaviour to test:

• fix(zarr-metadata): bytes are not a JSON array #4423 bytes are not a JSON array
• fix(zarr-metadata): a v2 array's other members are JSON with string keys #4424 a v2 array's other members are JSON with string keys
• refactor(zarr-metadata): validators type an unread document as what it is #4425 validators type an unread document as what it is
• fix(zarr-metadata): a model shares nothing with the document it read #4426 a model shares nothing with the document it read
• refactor(zarr-metadata): model casts that only restated a type are gone #4427 model casts that only restated a type are gone
• fix(zarr-metadata): the store reader checks that it read bytes #4428 the store reader checks that it read bytes
• fix(zarr-metadata)!: guards narrow only when they say yes #4429 guards narrow only when they say yes
• fix(zarr-metadata): the v2 group document types are closed #4430 the v2 group document types are closed

#4425, #4426, #4428 and #4430 have merged, as have #4420, #4421 and #4422, and each of the four left is rebased onto them, so its tests are type-checked as #4421 requires. Of those four, only #4423 and #4429 touch the same lines, the TypeGuard import, so whichever of them merges second needs a one-line rebase. All eight together, merged with #4421's type-checked tests, pass just check.

🤖 Generated with Claude Code

[read-the-docs-community]

Documentation build overview

📚 zarr-metadata | 🛠️ Build #34777869 | 📁 Comparing f83d661 against latest (4aeac75)

  🔍 Preview build  

3 files changed

± api/model/index.html
± api/pydantic/index.html
± api/v2/index.html