fix: bEngine now downloads and mounts the actual model checkpoint - #65
Merged
Conversation
bEngine's container runner always referenced a hardcoded, non-existent checkpoints/model.pth path instead of using the model registry's checkpoint URL carried on the benchmark event. event.ModelURL was logged but never used to fetch anything. Add Engine.PullModel to download the checkpoint from the configured S3 store (mirroring the existing PullDataset flow), and thread the resolved checkpoint name through RunContainer so the "-m" flag points at the file that was actually downloaded. When an event carries no ModelURL, skip the checkpoint entirely instead of mounting a fabricated "model.pth".
zeddo123
added
enhancement
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bEngine's container runner always referenced a hardcoded, non-existent checkpoints/model.pth path instead of using the model registry's checkpoint URL carried on the benchmark event. event.ModelURL was logged but never used to fetch anything.
Add Engine.PullModel to download the checkpoint from the configured S3 store (mirroring the existing PullDataset flow), and thread the resolved checkpoint name through RunContainer so the "-m" flag points at the file that was actually downloaded. When an event carries no ModelURL, skip the checkpoint entirely instead of mounting a fabricated "model.pth".