refactor(Tests): migrate OpenApiTestCase to extracted traits - #2157
Merged
DerManoMann merged 2 commits intoSep 3, 2026
Conversation
Extract UsesFixtures trait and compose ExpectsLogEntries, AssertsSpecEquals and UsesFixtures into OpenApiTestCase. Migrate all test files from the old logger API to ExpectsLogEntries. Remove dead initializeProcessors() and move SourceScannerTest to plain TestCase. What remains on OpenApiTestCase is classic-only and deletable with classic in v8. Written with Claude.
DerManoMann
added a commit
to DerManoMann/swagger-php
that referenced
this pull request
Sep 3, 2026
Add zircote#2154 (input validation), zircote#2155 (ref escaping), zircote#2156 (Server summaries) and zircote#2157 (OpenApiTestCase trait migration) to the merged list. Remove PR 10 from the suggested order and move its full write-up to the archive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UsesFixturestrait (fixture()/fixtures()path helpers)ExpectsLogEntries,AssertsSpecEquals, andUsesFixturesintoOpenApiTestCaseassertOpenApiLogEntryContains,ignoreLogEntries,getTrackingLogger) to theExpectsLogEntriestrait API (expectLogEntry,allowLogEntry,trackingLogger)initializeProcessors()method (zero callers)SourceScannerTestoffOpenApiTestCaseto plainTestCase— it needed nothing classicallowClassicDebugNoise()hook to suppress the "Analysing source:" and "JetBrains" debug entries the old logger silently droppedWhat remains on
OpenApiTestCaseis classic-only:getContext,getAnalyzer,processorPipeline,analysisFromFixtures,annotationsFromDocBlockParser,createOpenApiWithInfo,allAnnotationClasses,allAttributeClasses,getTypeResolver,getTypeResolvers. All deletable with classic in v8.Test plan