Skip to content

fix: Allow local IP addresses during validation of an onboarding service - #4887

Open
pavel-jares-bcm wants to merge 4 commits into
v3.x.xfrom
reboot/v3-add-local-ip-to-allowed-ones
Open

fix: Allow local IP addresses during validation of an onboarding service#4887
pavel-jares-bcm wants to merge 4 commits into
v3.x.xfrom
reboot/v3-add-local-ip-to-allowed-ones

Conversation

@pavel-jares-bcm

@pavel-jares-bcm pavel-jares-bcm commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

When configuration of a service does not provided a IP address value Eureka automatically set one. It is first found non-loopbak IPv4 address. It could happened that this address is from another network interface and therefore cannot be validated (the current implementation just translate local hostname to IP address). This issue could happened in many services, so this PR adds all local addresses as allowed. In case of HA the issue still remaining because one instance of DS couldn't know about the whole list of other LPAR. Anyway this PR improve the situation. The follow up US could rewrite Eureka default translation to respect host name.

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

@pull-request-size pull-request-size Bot added size/L and removed size/M labels Aug 12, 2026
@pavel-jares-bcm
pavel-jares-bcm marked this pull request as ready for review August 12, 2026 12:43
@pablocarle

Copy link
Copy Markdown
Contributor

Check sonar issues please

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants