Repository navigation
feat: Spec empty string flag values - #22
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
emyller
requested review from
khvn26 and
kyle-ssg
and removed request for
a team
November 4, 2026 20:36
khvn26
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDKs must serve a flag whose value is an empty string as
"", notnull. The Elixir SDK turned""intonullwhen parsing both API responses and environment documents, and no spec scenario caught it (Flagsmith/flagsmith-elixir-client#67 (comment)).Changes
Verified locally: the Elixir SDK fails all three scenarios before Flagsmith/flagsmith-elixir-client@88799af and passes them after it.
Contributes to Flagsmith/flagsmith-elixir-client#67
Review effort: 1/5
🤖 Generated with Claude Code