Skip to content

feat: Spec empty string flag values #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emyller merged 1 commit into from
Nov 4, 2026
Merged

feat: Spec empty string flag values #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions features/get_environment_flags.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ Feature: Get environment flags
| max_items | false | 42 |
| dark_mode | true | true |
| beta | true | null |
| tagline | true | "" |
When the application gets the environment flags
Then the application receives the following flags:
| feature | enabled | value |
| banner | true | "welcome" |
| max_items | false | 42 |
| dark_mode | true | true |
| beta | true | null |
| tagline | true | "" |
2 changes: 2 additions & 0 deletions features/get_identity_flags.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Feature: Get identity flags with traits
| feature | enabled | value |
| banner | true | "hello" |
| max_items | true | 10 |
| tagline | true | "" |
And a segment "premium_users" where trait "plan" equals "premium"
And segment "premium_users" overrides feature "banner" with enabled true and value "hello premium user"
When the application gets the flags for identity "user_123" with traits:
Expand All @@ -23,6 +24,7 @@ Feature: Get identity flags with traits
| feature | enabled | value |
| banner | true | "hello premium user" |
| max_items | true | 10 |
| tagline | true | "" |
And Flagsmith has identity "user_123" with the following traits:
| trait | value |
| plan | "premium" |
Expand Down
2 changes: 2 additions & 0 deletions features/local__get_environment_flags.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Feature: Get environment flags with local evaluation
| checkout | true | "v2" |
| search | true | null |
| autocomplete | true | 5 |
| tagline | true | "" |
And feature "checkout" depends on feature "payments"
And feature "autocomplete" depends on feature "search"
When the application gets the environment flags
Expand All @@ -23,6 +24,7 @@ Feature: Get environment flags with local evaluation
| checkout | false | "v2" |
| search | true | null |
| autocomplete | true | 5 |
| tagline | true | "" |

Scenario: Environment flags ignore segments that need an identity
Given the environment has the following features:
Expand Down
Loading