Cleanup stale todos - #2832
Conversation
Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughRemoved an obsolete commented-out Merge Risk: ⚪ Minimal · up to This change removes obsolete TODOs and an unused code stub without changing behavior; no actionable merge-blocking risk remains after normal checks and review. Comment |
|
@rahulait done! ptal |
Description
Combines two small cleanup changes (previously #2830 and a separate nodepool.go PR, merged per reviewer request):
validate()function stub and its TODO comment instate_manager.go.Never implemented, nothing references it.
// TODO: add unit testscomment innodepool.go.Test coverage already exists in
nodepool_test.go(6 test functions).No functional changes in either commit.
Testing
go build ./...and full test suite forcontrollersandinternal/statepackages, all pass.