Repository navigation
fix: Trie.keysWithPrefix ignores case in a case-insensitive trie - #802
Open
OsamaAnsar wants to merge 1 commit into
Open
OsamaAnsar wants to merge 1 commit into
OsamaAnsar wants to merge 1 commit into
Conversation
keysWithPrefix read this.caseSensitive, which is never set, so it did not lower-case the prefix the way contains, findPrefix and findMatchesOnPath do. A prefix with an upper-case letter found nothing.
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trie made with
new Trie(false)is case-insensitive incontains,findPrefixandfindMatchesOnPath, but not inkeysWithPrefix:keysWithPrefixreadsthis.caseSensitive, which is never set. The constructor stores the flag asthis.cs, and the other methods read that. The prefix is therefore never lower-cased.The change reads
this.cs. Two new specs cover the case-insensitive and the default case-sensitive trie; the first fails without the change.npm test(900 specs) andnpm run lintpass.