Skip to content

Add schema fields from 2 PR's and backfill data - #767

Merged
coffandro merged 2 commits into
mainfrom
more_fields
Oct 28, 2026
Merged

coffandro merged 2 commits into
mainfrom
more_fields

Conversation

@coffandro

Copy link
Copy Markdown
Collaborator

Fixes #735
Fixes #734

@coffandro
coffandro requested a balanced review from Copilot October 26, 2026 16:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

- Add inverted_range data-quality rule (min > max for print/bed temp, fan speed,
  and dry_temperature vs max_dry_temperature) with tests
- Fix swapped bed temperatures on 3deksperten Pirate Black caught by the rule
- Give dry_temperature a minimum of 0 like the other new fields
- Filament page: show fan speed and drying rows when only one side is set,
  and read enclosure labels from the schema's x-enum-labels

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coffandro
coffandro merged commit 422da33 into main Oct 28, 2026
10 checks passed
@coffandro
coffandro deleted the more_fields branch October 28, 2026 16:26
coffandro pushed a commit that referenced this pull request Oct 31, 2026
…767 fields)

Values from the manufacturers' product pages / technical data sheets, mapped as described in the PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8a6Te45fbpikDxHXroeG8
coffandro added a commit that referenced this pull request Oct 31, 2026
FormFutura, AURAPOL: drying temperature and time for 8 filaments (new #767 fields)
coffandro pushed a commit that referenced this pull request Oct 31, 2026
…ts (new #767 fields)

Values from the manufacturers' product pages / technical data sheets, mapped as described in the PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8a6Te45fbpikDxHXroeG8
coffandro added a commit that referenced this pull request Oct 31, 2026
extrudr: fan speed, max volumetric speed and enclosure for 20 filaments (new #767 fields)
coffandro pushed a commit that referenced this pull request Oct 31, 2026
…fields)

Values from the manufacturers' product pages / technical data sheets, mapped as described in the PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8a6Te45fbpikDxHXroeG8
coffandro added a commit that referenced this pull request Oct 31, 2026
Spectrum: fan speed, enclosure and drying for 72 filaments (new #767 fields)
coffandro pushed a commit that referenced this pull request Nov 3, 2026
…new #767 fields) (#818)

* Add-North: recommended drying temperature and time for 21 filaments (new #767 fields)

Values from the manufacturers' product pages / technical data sheets, mapped as described in the PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8a6Te45fbpikDxHXroeG8

* Add-North: update drying values to the current product data

Add-North changed the drying recommendations on its product pages after
these values were collected (02.10.2026). Updated to the current data,
same mapping as before (lower temperature, upper hours):

- 65 °C: Adura, Adura FDA, Adura X, Rigid X, rPETG Matte (6 h),
  ESD PETG, PETG (4 h); PETG PRO Matte 60 °C / 4 h;
  PC Blend HT LCF 70 °C / 4 h.
- rABS: dry_temperature left out — the new 70 °C is above the existing
  max_dry_temperature (65 °C); dry_time 6 h stays.
- Addlantis: dry_time left out — product data 6 h, product text
  "at least 8 hours".
- PETG Flame Retardant V0: both values left out — product data
  65 °C / 3-4 h, product text 60 °C / 6-8 h.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8a6Te45fbpikDxHXroeG8

---------

Co-authored-by: Makemo07 <194791348+Makemo07@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants