Skip to content

Skip FOD estimation by dropping fod section - #398

Merged
tsalo merged 11 commits into
mainfrom
simplify-estimation
Aug 18, 2026
Merged

tsalo merged 11 commits into
mainfrom
simplify-estimation

Conversation

@tsalo

@tsalo tsalo commented Aug 14, 2026

Copy link
Copy Markdown
Member

Closes #362.

Changes proposed in this pull request

  • Restructure init_mrtrix_csd_recon_wf to skip FOD estimation when users don't want it. It will write out all three response function files (WM, GM, CSF) even if only WM is used later.

@tsalo tsalo added the refactor label Aug 14, 2026
@tsalo
tsalo requested a review from araikes August 14, 2026 15:40
@codecov-commenter

codecov-commenter commented Aug 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.50%. Comparing base (38e5900) to head (317a198).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
qsirecon/workflows/recon/mrtrix.py 76.00% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   50.47%   50.50%   +0.03%     
==========================================
  Files          55       55              
  Lines        8139     8148       +9     
  Branches      944      947       +3     
==========================================
+ Hits         4108     4115       +7     
+ Misses       3792     3791       -1     
- Partials      239      242       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo
tsalo merged commit 558723f into main Aug 18, 2026
29 checks passed
@tsalo
tsalo deleted the simplify-estimation branch August 18, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Estimate response functions needs a parameter option

3 participants