Perf review, melee fixes and damage display refactor - #23
Merged
Merged
Conversation
chore: add native appsettings config refactor design spec Design for migrating Silo/Client/tools from the custom ConfigurationUtilities.GetConfiguration scheme to the native .NET host config chain, replacing CommunicationOptions and the Postgres connection string with native ConnectionStrings, removing RESOLVER_ENVIRONMENT, and renaming the orleansdb container to resolverpostgres. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> @
…ross-file read Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…_ENVIRONMENT Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ionStrings env vars
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
refactor: inject ServerToClientCommunicator; construct Redis consumers manually CommunicationService now injects a DI-registered ServerToClientCommunicator instead of building it from a connection string, dropping its IConfiguration/options/DataHelper/ grainFactory params. ServerToClientCommunicator and ResolverCommunicator are registered via manual factories that pass the Redis connection string resolved at the composition root - uniform with the repository factories. No keyed services or wrapper type needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> @
…mageResolver into damagedisplayrefactorbranch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A zillion billion changes.