Perf review, melee fixes and damage display refactor

.dockerignore

@@ -0,0 +1,7 @@
+**/bin/
+**/obj/
+**/.vs/
+**/*.user
+.git/
+.github/
+CustomNugets/

.editorconfig

@@ -703,6 +703,9 @@ dotnet_diagnostic.IDE0280.severity = suggestion
 # Disagree about clarity of primary constructor
 dotnet_diagnostic.IDE0290.severity = none
 
+# .ToList() is just fine
+dotnet_diagnostic.IDE0305.severity = none
+
 ##
 ## StyleCop.Analyzers
 ##

.gitattributes

@@ -1,4 +1,5 @@
 * text auto
+*.sh text eol=lf
 *.cdr -text
 *.exe -text
 *.dll -text

.github/workflows/build.yml

@@ -0,0 +1,34 @@
+name: Build and test
+
+# Minimal CI: builds the self-contained server solution and runs the test project.
+# The BlazorServer client is intentionally excluded because it consumes the Api/Common
+# packages from the local CustomNugets feed produced by the build pipeline, which is not
+# available on a clean CI runner.
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: '10.0.x'
+
+      - name: Restore
+        run: dotnet restore BtDamageResolver/BTDamageResolver.slnx
+
+      - name: Build
+        run: dotnet build BtDamageResolver/BTDamageResolver.slnx --configuration Release --no-restore
+
+      - name: Test
+        run: dotnet test BtDamageResolver/tests/Tests/Tests.csproj --configuration Release --no-build

.gitignore

@@ -9,6 +9,7 @@
 *.userosscache
 *.sln.docstates
 *.ruleset
+**dpkeys
 
 # Build results
 [Dd]ebug/
@@ -42,7 +43,6 @@ dlldata.c
 project.lock.json
 project.fragment.lock.json
 artifacts/
-**/Properties/launchSettings.json
 
 # StyleCop
 StyleCopReport.xml
@@ -161,8 +161,6 @@ __pycache__/
 # Docker-Compose environment
 infra/.env
 
-# Possible sensitive resource files
-infra/dpkeys/
-
 # Debug settings containing password data
 *.Debug.json
+*.Development.json

BtDamageResolver/data/ammo/Ammo_AC.json

@@ -1,6 +1,7 @@
 [
   {
     "Name": "AC-AP2",
+    "AmmoProxyName": "AP",
     "HitModifier": 1,
     "SpecialFeatures": [
       { "Data": "-4", "Type": "ArmorPiercing" },
@@ -10,6 +11,7 @@
   },
   {
     "Name": "AC-AP5",
+    "AmmoProxyName": "AP",
     "HitModifier": 1,
     "SpecialFeatures": [
       { "Data": "-3", "Type": "ArmorPiercing" },
@@ -19,6 +21,7 @@
   },
   {
     "Name": "AC-AP10",
+    "AmmoProxyName": "AP",
     "HitModifier": 1,
     "SpecialFeatures": [
       { "Data": "-2", "Type": "ArmorPiercing" },
@@ -28,15 +31,25 @@
   },
   {
     "Name": "AC-AP20",
+    "AmmoProxyName": "AP",
     "HitModifier": 1,
     "SpecialFeatures": [
       { "Data": "-1", "Type": "ArmorPiercing" },
       { "Type": "TargetingComputerValid" },
       { "Type": "TargetingComputerValidAimed" }
     ]
   },
+  {
+    "Name": "AC-Slug",
+    "AmmoProxyName": "Slug",
+    "SpecialFeatures": [
+     { "Type": "TargetingComputerValid" },
+     { "Type": "TargetingComputerValidAimed" }
+   ]
+  },
   {
     "Name": "AC-LBXCluster",
+    "AmmoProxyName": "Cluster",
     "HitModifier": -1,
     "SpecialFeatures": [
       { "Type": "Cluster" },
@@ -47,6 +60,7 @@
   },
   {
     "Name": "AC-Single",
+    "AmmoProxyName": "Normal",
     "SpecialFeatures": [
      { "Type": "TargetingComputerValid" },
      { "Type": "TargetingComputerValidAimed" }

BtDamageResolver/data/ammo/Ammo_ATM.json

@@ -1,6 +1,7 @@
 [
   {
     "Name": "ATM3-SRM",
+    "AmmoProxyName": "SRM",
     "Damage": {
       "Short": 9
     },
@@ -19,6 +20,7 @@
   },
   {
     "Name": "ATM3-MRM",
+    "AmmoProxyName": "MRM",
     "Damage": {
       "Short": 6
     },
@@ -38,6 +40,7 @@
   },
   {
     "Name": "ATM3-LRM",
+    "AmmoProxyName": "LRM",
     "Damage": {
       "Short": 3
     },
@@ -57,6 +60,7 @@
   },
   {
     "Name": "ATM6-SRM",
+    "AmmoProxyName": "SRM",
     "Damage": {
       "Short": 18
     },
@@ -75,6 +79,7 @@
   },
   {
     "Name": "ATM6-MRM",
+    "AmmoProxyName": "MRM",
     "Damage": {
       "Short": 12
     },
@@ -94,6 +99,7 @@
   },
   {
     "Name": "ATM6-LRM",
+    "AmmoProxyName": "LRM",
     "Damage": {
       "Short": 6
     },
@@ -113,6 +119,7 @@
   },
     {
     "Name": "ATM9-SRM",
+    "AmmoProxyName": "SRM",
     "Damage": {
       "Short": 27
     },
@@ -131,6 +138,7 @@
   },
   {
     "Name": "ATM9-MRM",
+    "AmmoProxyName": "MRM",
     "Damage": {
       "Short": 18
     },
@@ -150,6 +158,7 @@
   },
   {
     "Name": "ATM9-LRM",
+    "AmmoProxyName": "LRM",
     "Damage": {
       "Short": 9
     },
@@ -169,6 +178,7 @@
   },
   {
     "Name": "ATM12-SRM",
+    "AmmoProxyName": "SRM",
     "Damage": {
       "Short": 36
     },
@@ -187,6 +197,7 @@
   },
   {
     "Name": "ATM12-MRM",
+    "AmmoProxyName": "MRM",
     "Damage": {
       "Short": 24
     },
@@ -206,6 +217,7 @@
   },
   {
     "Name": "ATM12-LRM",
+    "AmmoProxyName": "LRM",
     "Damage": {
       "Short": 12
     },
@@ -223,4 +235,4 @@
     "RangeMinimum": 4,
     "SpecialFeatures": [ { "Type": "Cluster" } ]
   }
-]
+]

BtDamageResolver/data/ammo/Ammo_Generic.json

@@ -6,7 +6,7 @@
     "Name": "Missile",
     "SpecialFeatures": [ { "Type": "Cluster" } ]
   },
-  {
+    {
     "Name": "Missile+Artemis",
     "SpecialFeatures": [ { "Type": "Cluster" } ],
     "ClusterBonus": {
@@ -17,6 +17,20 @@
     "Name": "MissileHoming",
     "SpecialFeatures": [ { "Type": "Cluster" }, { "Type": "Homing" } ]
   },
+  {
+    "Name": "MissileHoming+Inferno",
+    "Damage": {
+      "Short": 0
+    },
+    "DamageAerospace": {
+      "Short": 0
+    },
+    "SpecialDamage": [
+      { "Data": "3", "Type": "Burst" },
+      { "Data": "2", "Type": "Heat" }
+    ],
+    "SpecialFeatures": [ { "Type": "Cluster" }, { "Type": "Homing" } ]
+  },
   {
     "Name": "MissileHoming+Artemis",
     "SpecialFeatures": [ { "Type": "Cluster" }, { "Type": "Homing" } ],

BtDamageResolver/data/ammo/Ammo_LRM.json

@@ -135,4 +135,4 @@
     "HitModifier": 1,
     "SpecialFeatures": [ { "Type": "Cluster" }, { "Type": "Homing" }, { "Type": "IndirectFire" } ]
   }
-]
+]