Repository navigation
[REFACTOR][IR] Colocate and inline expression FFI traits - #20585
Merged
Merged
Conversation
tqchen
force-pushed
the
ir/expr-ffi-traits
branch
from
October 7, 2026 11:46
3c31172 to
8785e8a
Compare
tqchen
changed the title
MasterJH5574
approved these changes
Oct 7, 2026
tqchen
force-pushed
the
ir/expr-ffi-traits
branch
from
October 7, 2026 16:08
8785e8a to
6d9d481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define Expr, PrimExpr, and the dependent IntExpr FFI traits beside the complete literal classes in expr.h, with their opt-outs and scalar/string conversion definitions in the same header.
Define recursive Expr array-to-Tuple conversion with ordinary inline after Tuple is complete. This retains recursive sequence conversion and expression identity while removing the out-of-line conversion definitions from expr.cc.