Skip to content

[REFACTOR][IR] Colocate and inline expression FFI traits #20585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 2 commits into from
Oct 7, 2026
Merged

[REFACTOR][IR] Colocate and inline expression FFI traits #20585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc9df59
[REFACTOR][IR] Colocate expression traits and convert arrays to tuples
tqchen Oct 7, 2026
6d9d481
[REFACTOR][IR] Keep expression conversion traits entirely in expr.h
tqchen Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 0 additions & 69 deletions include/tvm/ir/base_expr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,75 +528,6 @@ struct TypeTraits<TypedExpr<ExpectedType>>
}
};

template <>
inline constexpr bool use_default_type_traits_v<PrimExpr> = false;

// define automatic conversion from bool, int64_t, double to PrimExpr
// These functions are declared early to avoid circular dependency
template <>
struct TypeTraits<PrimExpr>
: public ObjectRefWithFallbackTraitsBase<PrimExpr, StrictBool, int64_t, double> {
using Base = ObjectRefWithFallbackTraitsBase<PrimExpr, StrictBool, int64_t, double>;
TVM_FFI_INLINE static bool CheckAnyStrict(const TVMFFIAny* src) {
if (src->type_index == TypeIndex::kTVMFFINone) return PrimExpr::_type_is_nullable;
return TypeTraits<TypedExpr<PrimType>>::CheckAnyStrict(src);
}

TVM_FFI_INLINE static std::optional<PrimExpr> TryCastFromAnyView(const TVMFFIAny* src) {
// A required expression cannot accept None.
if (src->type_index == TypeIndex::kTVMFFINone) return std::nullopt;
return Base::TryCastFromAnyView(src);
}

TVM_FFI_INLINE static std::string TypeStr() { return "ir.PrimExpr"; }

TVM_FFI_INLINE static std::string GetMismatchTypeInfo(const TVMFFIAny* src) {
return TypeTraits<TypedExpr<PrimType>>::GetMismatchTypeInfo(src);
}

TVM_DLL static PrimExpr ConvertFallbackValue(StrictBool value);
TVM_DLL static PrimExpr ConvertFallbackValue(int64_t value);
TVM_DLL static PrimExpr ConvertFallbackValue(double value);
};

template <>
inline constexpr bool use_default_type_traits_v<IntExpr> = false;

template <>
struct TypeTraits<IntExpr> : public ObjectRefWithFallbackTraitsBase<IntExpr, int64_t> {
using Base = ObjectRefWithFallbackTraitsBase<IntExpr, int64_t>;

TVM_FFI_INLINE static bool CheckAnyStrict(const TVMFFIAny* src) {
if (!Base::CheckAnyStrict(src)) return false;
if (src->type_index == TypeIndex::kTVMFFINone) return true;
const auto* expr = details::ObjectUnsafe::RawObjectPtrFromUnowned<ExprNode>(src->v_obj);
const auto* ty = expr->ty.as<PrimTypeNode>();
return ty != nullptr && ty->dtype.lanes == 1 &&
(ty->dtype.code == kDLInt || ty->dtype.code == kDLUInt);
}

TVM_FFI_INLINE static IntExpr ConvertFallbackValue(int64_t value) {
return TypeTraits<PrimExpr>::ConvertFallbackValue(value).as_or_throw<IntExpr>();
}

TVM_FFI_INLINE static std::string TypeStr() { return "ir.IntExpr"; }

TVM_FFI_INLINE static std::string GetMismatchTypeInfo(const TVMFFIAny* src) {
return TypeTraits<TypedExpr<PrimType>>::GetMismatchTypeInfo(src);
}
};

template <>
inline constexpr bool use_default_type_traits_v<Expr> = false;

// Allow generic Expr arguments to use the primitive-literal conversions
// already defined by PrimExpr.
template <>
struct TypeTraits<Expr> : public ObjectRefWithFallbackTraitsBase<Expr, PrimExpr, ffi::String> {
TVM_FFI_INLINE static Expr ConvertFallbackValue(PrimExpr value) { return value; }
TVM_DLL static Expr ConvertFallbackValue(ffi::String value);
TVM_DLL static std::optional<Expr> TryCastFromAnyView(const TVMFFIAny* src);
};
} // namespace ffi

} // namespace tvm
Expand Down
Loading
Loading