Repository navigation
[ty] Preserve recursive aliases when rebuilding intersections - #29057
Open
charliermarsh wants to merge 7 commits into
Open
charliermarsh wants to merge 7 commits into
charliermarsh wants to merge 7 commits into
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146. |
Memory usage reportMemory usage unchanged ✅ |
|
Merging this PR will degrade performance by 4.19%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
charliermarsh
marked this pull request as ready for review
October 1, 2026 20:44
charliermarsh
force-pushed
the
charlie/ty-3195-recursive-complement
branch
from
October 5, 2026 14:43
8fdf4c1 to
5e7339c
Compare
ibraheemdev
reviewed
Oct 6, 2026
charliermarsh
marked this pull request as draft
October 6, 2026 20:16
charliermarsh
marked this pull request as ready for review
October 6, 2026 20:32
charliermarsh
requested review from
ibraheemdev
and removed request for
carljm
October 6, 2026 20:35
charliermarsh
added this pull request to stack #29153
October 6, 2026 20:54
charliermarsh
removed this pull request from stack #29153
October 7, 2026 00:09
charliermarsh
force-pushed
the
charlie/ty-3195-recursive-complement
branch
from
October 7, 2026 02:00
064192d to
9d7b5bb
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We avoid panics and hangs when recursive aliases appear in mapped intersections. Both negated and positive aliases retain their identity when the intersection does not need to simplify them. For example, indexing a recursive list containing a complement now yields
object:The same applies when specialization puts a recursive tuple alias into a positive intersection:
The intersection builder expands set operations for distribution and flattening, then inspects the types behind aliases when simplifying the resulting intersections. This preserves existing rules for
object,Never, double negation, truthiness, enums, and gradual generics while avoiding repeated expansion of unchanged recursive aliases. Type comparisons still treat aliased and expanded intersections as equivalent, including those containing gradual types.The invalid
x[]form in the issue now reports a syntax error without panicking.Closes astral-sh/ty#3195.