Repository navigation
[ty] Avoid hangs on recursive tuple aliases in positive intersections - #29152
Closed
charliermarsh wants to merge 1 commit into
Closed
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.24%. The percentage of expected errors that received a diagnostic held steady at 98.24%. The number of fully passing files held steady at 134/146. |
Memory usage reportMemory usage unchanged ✅ |
|
| Project | Old Time | New Time | Change |
|---|---|---|---|
more-itertools |
0.13s | 0.21s | +60% |
charliermarsh
force-pushed
the
charlie/ty-shared-recursion-guards
branch
from
October 6, 2026 20:53
acc8ca7 to
bca1de0
Compare
charliermarsh
changed the base branch from
main
to
charlie/ty-3195-recursive-complement
October 6, 2026 20:53
charliermarsh
added this pull request to stack #29153
October 6, 2026 20:54
charliermarsh
marked this pull request as ready for review
October 6, 2026 20:54
charliermarsh
removed this pull request from stack #29153
October 7, 2026 00:09
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #29057. We now handle recursive tuple aliases specialized into positive intersections without hanging:
Previously, mapping the intersection unfolded
Aagain after its mapping had completed. Each reconstruction could introduce another copy of the tuple, so even revealingxwould not terminate.We extend the existing alias-preservation mode to positive elements. The builder retains aliases to non-
objectnominal instances on the positive side and continues to apply its sign-specific rules for negated aliases. Aliases that exposeobjector set operations still expand, and ordinary intersection redundancy checks still run. The regressions cover both alias syntaxes, the returned element type, and an invalid assignment.