backend: Improve error handling; frontend: Display error in tooltip - #291
Merged
Merged
Conversation
The upstream PingError only derives Debug, so a device timeout reaches the user as a nested Debug chain. Map each variant to a sentence.
Give ManagerError and DeviceStatus a Display so callers can show a readable sentence instead of a Debug chain.
EpicEric
force-pushed
the
error-recovery
branch
2 times, most recently
from
September 22, 2026 16:34
539d6de to
dfc197e
Compare
Member
|
@EpicEric I asked @joaoantoniocardoso to help us with the code reviewing while Patrick is out. |
joaoantoniocardoso
left a comment
joaoantoniocardoso
left a comment
Member
There was a problem hiding this comment.
Hi, I'm not familiar with the codebase anymore, but here's some quick review.
…ing the device Leave the map entry as Available so a later recover can reopen the source and respawn the actor.
…sMode Tear down the dead runtime and reuse auto-create so a user retry can bring the actor back instead of returning DeviceStatus(Error). Stop continuous streaming before teardown. Aborting alone left Ping devices streaming on the BlueOS bridge, so the next handshake timed out while BlueOS still showed the sensor as connected.
Retry recreate with exponential backoff so a flaky link can come back without waiting for a UI click, while EnableContinuousMode still recovers immediately.
… Error Surface subscriber, actor, and timeout dead ends through mark_error so auto-heal can retry instead of skipping the device forever.
The backend serializes Error as a tagged object, so a shared helper is needed to derive the chip kind, colour, and reason.
A device in Error was falling through to the Available chip, hiding why it stopped.
A device in Error was falling through to the Available chip, hiding why it stopped.
A device in Error was falling through to the Available chip, hiding why it stopped.
A device in Error was falling through to the Available chip, hiding why it stopped.
EpicEric
force-pushed
the
error-recovery
branch
from
September 23, 2026 15:44
dfc197e to
a97c489
Compare
joaoantoniocardoso
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #290
Device disconnected:
Device reconnected on a different port:
EnableContinuousMode recovery has also been fixed (i.e. sending a stop signal before restarting the actor) but there's no good way to display that flow via screenshots