Repository navigation
37 fix minows partial streams - #43
Merged
Merged
Conversation
JonKuqi
marked this pull request as ready for review
August 25, 2026 13:49
JonKuqi
force-pushed
the
37-fix-minows-partial-streams
branch
from
August 25, 2026 16:48
08f5b05 to
7f1c55e
Compare
JonKuqi
force-pushed
the
37-fix-minows-partial-streams
branch
from
August 26, 2026 15:04
7f1c55e to
954aa5a
Compare
JonKuqi
force-pushed
the
37-fix-minows-partial-streams
branch
from
August 26, 2026 15:23
954aa5a to
6e7350e
Compare
JonKuqi
force-pushed
the
37-fix-minows-partial-streams
branch
from
August 26, 2026 15:26
6e7350e to
c77c47b
Compare
JonKuqi
force-pushed
the
37-fix-minows-partial-streams
branch
from
August 27, 2026 08:06
c77c47b to
5bf0b87
Compare
JonKuqi
force-pushed
the
37-fix-minows-partial-streams
branch
from
August 27, 2026 08:07
5bf0b87 to
e9c7a3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
Problem
D-Voting and DELA ordering use threshold protocols that are expected to continue when the configured threshold allows node failures.
Before this PR, MinoWS returned an error as soon as any participant connection failed. That prevented the threshold layer from receiving a sender/receiver pair and applying its own failure threshold.
Fix
Streamnow fails only when no participant connection could be opened:If some participants are reachable, the stream is created over that subset. Sends to unavailable participants still return ErrNotPlayer, allowing the threshold protocol to count those failures normally.
Verification
go test ./mino/minows -count=1
The partial-connectivity and no-reachable-player tests pass, and all D-Voting integration and system tests pass with the updated DELA revision.