Repository navigation
Extractor for SK managed file which have implicit ts - #25
Merged
Merged
Conversation
samuelsov
marked this pull request as draft
December 17, 2025 22:55
samuelsov
force-pushed
the
skextractor
branch
from
December 18, 2025 00:02
11851f0 to
bd428ea
Compare
samuelsov
marked this pull request as ready for review
December 18, 2025 00:02
Contributor
|
jenkins test please |
totten
reviewed
Feb 20, 2026
| $cases[] = array(array("examples/ex4.cmd", "examples/ex4.hlp", "examples/ex4.install", "examples/ex4.module", "examples/ex4.tpl", "examples/ex4.js", "examples/ex4.cmd2", "examples/ex4.txt"), "examples/ex4.pot"); | ||
| $cases[] = array(array("examples/ex5.html"), "examples/ex5.pot"); | ||
| $cases[] = array(array("examples/Event.setting.php"), "examples/event.setting.pot"); | ||
| $cases[] = array(array("examples/sk1.mgd.php"), "examples/sk1.mgd.pot"); |
Member
There was a problem hiding this comment.
Mismatch: File is named sk1.pot and the $cases reference sk1.mgd.pot. They should match.
Member
There was a problem hiding this comment.
Thanks @totten ! I took the liberty of updating the test.
Contributor
|
@mlutfy is this mergeable? |
Member
|
Reviewed with @samuelsov at the sprint and took the liberty to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complement to civicrm/civicrm-core#33901 where we remove ts from SK managed files to make string translatable dynamically.
We need to change the extractor to get those strings in transifex even if they don't have
ts()anymore.