fix(config): preserve runtime objects in blueprint configuration - #3373
Draft
Nabla7 wants to merge 1 commit into
Draft
fix(config): preserve runtime objects in blueprint configuration#3373Nabla7 wants to merge 1 commit into
Nabla7 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3373 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 1172 1172
Lines 113568 113599 +31
Branches 10258 10264 +6
=======================================
+ Hits 86090 86114 +24
- Misses 24492 24495 +3
- Partials 2986 2990 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Preserve explicitly configured callable and opaque Python values after Pydantic validation instead of serializing them through
model_dump().A regression test sends a callable dataclass through blueprint parsing, pickle worker serialization, and Pydantic reconstruction.
Root cause
BlueprintConfigParservalidated module configuration correctly, thenmodel_dump(mode="python")converted nested dataclasses into plain dictionaries. Rerun callbacks and other runtime objects therefore stopped being callable after crossing the worker boundary.Validation
pytest dimos/core/coordination/blueprint_config/test_parser.py -q