Skip to content

Make data provider static. - #51

Merged
JojoVes merged 2 commits into
mainfrom
fix/tests
Jun 30, 2026
Merged

JojoVes merged 2 commits into
mainfrom
fix/tests

Conversation

@adam-vessey

@adam-vessey adam-vessey commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Tests
    • Updated an internal test data provider to use a static method signature.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@adam-vessey, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cd9c73d1-47f7-4b22-8a35-df7a3022281a

📥 Commits

Reviewing files that changed from the base of the PR and between b8858fc and 9e4a0a6.

📒 Files selected for processing (1)
  • tests/src/Kernel/EmbargoKernelTestBase.php
📝 Walkthrough

Walkthrough

The mapping() data provider method in PermissionsMapKernelTest was changed from an instance method to a static method by updating its declaration to public static function mapping(): array. The returned permission-mapping array contents are unchanged.

Changes

Test Data Provider Update

Layer / File(s) Summary
Static data provider declaration
modules/migrate_embargoes_to_embargo/tests/src/Kernel/PermissionsMapKernelTest.php
The mapping() method signature is updated from public function mapping(): array to public static function mapping(): array; returned array contents remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

A hop, a skip, one word made bold,
"static" now joins the method told.
No data changed, no logic bent,
just a tiny rabbit-sized dev intent. 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: converting the data provider to a static method.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@adam-vessey adam-vessey added patch Backwards compatible bug fixes. and removed no-update labels Jun 30, 2026
@JojoVes
JojoVes merged commit 77537db into main Jun 30, 2026
6 checks passed
@JojoVes
JojoVes deleted the fix/tests branch June 30, 2026 19:10
@github-actions

Copy link
Copy Markdown

Tag generated by PR: v1.7.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Backwards compatible bug fixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants