Skip to content

Make data provider static. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JojoVes merged 2 commits into from
Jun 30, 2026
Merged

Make data provider static. #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8858fc
Make data provider static.
adam-vessey Jun 30, 2026
9e4a0a6
Make more data providers static.
adam-vessey Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/migrate_embargoes_to_embargo/tests/src/Kernel/PermissionsMapKernelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function testMapping(string $old, string $new) : void {
* - the old permission from which we are mapping; and,
* - the new permission to which we are mapping.
*/
public function mapping() : array {
public static function mapping() : array {
return [
'admin' => ['administer embargoes settings', 'administer embargo'],
'manage' => ['manage embargoes', 'manage embargo'],
Expand Down
4 changes: 2 additions & 2 deletions tests/src/Kernel/EmbargoKernelTestBase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ protected function setEmbargoPastUnpublishDate(EmbargoInterface &$embargo) {
/**
* Data provider for media operations.
*/
public function providerMediaFileOperations(): array {
public static function providerMediaFileOperations(): array {
return [
'View' => ['view'],
'Download' => ['download'],
Expand All @@ -123,7 +123,7 @@ public function providerMediaFileOperations(): array {
/**
* Data provider for node operations.
*/
public function providerNodeOperations(): array {
public static function providerNodeOperations(): array {
return [
'View' => ['view'],
'Edit' => ['edit'],
Expand Down
Loading