Skip to content

[scout] migrate x-pack/platform/test/accessibility/apps/group1/dashboard_links to scout - #301737

Merged
nreese merged 5 commits into
elastic:mainfrom
nreese:issue_272644
Oct 30, 2026
Merged

[scout] migrate x-pack/platform/test/accessibility/apps/group1/dashboard_links to scout#301737
nreese merged 5 commits into
elastic:mainfrom
nreese:issue_272644

Conversation

@nreese

@nreese nreese commented Oct 29, 2026 •
edited by kibanamachine
Loading

Copy link
Copy Markdown
Contributor

Closes #272644
Closes #276442
Closes #274967

Fixes flakiness by removing save dashboard from test.

Also turns on links test in CI. Turns out they have been disabled this entire time - yikes

@nreese

nreese commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/ci

This was referenced Oct 29, 2026
Closed
Closed
@nreese

nreese commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/flaky scoutConfig:src/platform/plugins/private/links/test/scout/ui/playwright.config.ts:25

@kibanamachine

kibanamachine commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#15316

  • src/platform/plugins/private/links/test/scout/ui/playwright.config.ts x25

@nreese nreese mentioned this pull request Oct 29, 2026
Closed
@nreese

nreese commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/ci

@kibanamachine

kibanamachine commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#15316

[✅] src/platform/plugins/private/links/test/scout/ui/playwright.config.ts (--arch stateful --domain classic): 25/25 tests passed.

see run history

@nreese

nreese commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/ci

@nreese

nreese commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

/flaky scoutConfig:src/platform/plugins/private/links/test/scout/ui/playwright.config.ts:25

@kibanamachine

kibanamachine commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#15324

  • src/platform/plugins/private/links/test/scout/ui/playwright.config.ts x25

@nreese nreese mentioned this pull request Oct 29, 2026
Closed
@kibanamachine

kibanamachine commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#15324

[✅] src/platform/plugins/private/links/test/scout/ui/playwright.config.ts (--arch stateful --domain classic): 25/25 tests passed.

see run history

@nreese
nreese marked this pull request as ready for review October 29, 2026 22:47
@nreese
nreese requested review from a team as code owners October 29, 2026 22:48
@nreese
nreese requested a review from walterra October 29, 2026 22:48
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.6.0 v9.7.0 labels Oct 29, 2026
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

maryam-saeidi
maryam-saeidi approved these changes Oct 30, 2026
View reviewed changes

@maryam-saeidi maryam-saeidi left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think this pare in the PR description only closes the first ticket:

Closes #272644, #276442, #274967

Comment thread src/platform/plugins/private/links/test/scout/api/tests/create_links.spec.ts Resolved
Comment thread src/platform/plugins/private/links/test/scout/ui/tests/links_a11y.spec.ts Resolved
@nreese

nreese commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think this pare in the PR description only closes the first ticket:

It will close all the open tickets for dashboard_links test because the FTR test is being replaced by scout test - so no more FTR flakiness. Refactor removed a lot of unnecessary things like saving dashboards, selecting links, and so on and instead just uses pre-built dashboards.

@maryam-saeidi

maryam-saeidi commented Oct 30, 2026

Copy link
Copy Markdown
Member

I think this pare in the PR description only closes the first ticket:

It will close all the open tickets for dashboard_links test because the FTR test is being replaced by scout test - so no more FTR flakiness. Refactor removed a lot of unnecessary things like saving dashboards, selecting links, and so on and instead just uses pre-built dashboards.

Oh, I meant I think the command description will not work as expected, should we do it like this?

Closes #272644
Closes #276442
Closes #274967

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

💔 Build Failed

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 5.4MB 5.4MB +1.0B
Unknown metric groups

warm start memory

id before after diff
post forced gc heap baseline - 666997778 +666997778
post forced gc heap delta - -2693934 -2693934
post forced gc heap delta standard deviation - 2246792 +2246792
post forced gc heap target - 664303844 +664303844
tail heap delta - 3344074 +3344074
total +1334198554

Test Failures

  • [job] [logs] FTR Configs #14 / machine learning - anomaly detection - group 1 single metric job cloning with too short of a job creation time range results in validation callouts
  • [job] [logs] FTR Configs #36 / machine learning - anomaly detection - group 1 single metric job cloning with too short of a job creation time range results in validation callouts
  • [job] [logs] FTR Configs #36 / machine learning - anomaly detection - group 1 single metric job cloning with too short of a job creation time range results in validation callouts
  • [job] [logs] FTR Configs #14 / machine learning - anomaly detection - group 1 single metric job cloning with too short of a job creation time range results in validation callouts

History

@nreese
nreese added this pull request to the merge queue Oct 30, 2026
Merged via the queue into elastic:main with commit dad7b3d Oct 30, 2026
29 checks passed
@nreese
nreese deleted the issue_272644 branch October 30, 2026 17:34
@kibanamachine

kibanamachine commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.6

https://github.com/elastic/kibana/actions/runs/41099991592

@kibanamachine kibanamachine mentioned this pull request Oct 30, 2026
Merged
@kibanamachine

kibanamachine commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
✅ 9.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 30, 2026
@kibanamachine @nreese
[9.6] [scout] migrate x-pack/platform/test/accessibility/apps/group1/…
2f9ec8f 
…dashboard_links to scout (#301737) (#302145)

# Backport

This will backport the following commits from `main` to `9.6`:
- [[scout] migrate
x-pack/platform/test/accessibility/apps/group1/dashboard_links to scout
(#301737)](#301737)

<!--- Backport version: 12.1.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2026-10-30T17:06:52Z","message":"[scout]
migrate x-pack/platform/test/accessibility/apps/group1/dashboard_links
to scout (#301737)\n\nCloses
https://github.com/elastic/kibana/issues/272644\nCloses
https://github.com/elastic/kibana/issues/276442\nCloses
https://github.com/elastic/kibana/issues/274967\n\nFixes flakiness by
removing save dashboard from test.\n\nAlso turns on links test in CI.
Turns out they have been disabled this\nentire time -
yikes","sha":"dad7b3d9badda36eac1f2853a6b289917205fffd","branchLabelMapping":{"^v9.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:version","v9.6.0","v9.7.0"],"title":"[scout]
migrate x-pack/platform/test/accessibility/apps/group1/dashboard_links
to
scout","number":301737,"url":"https://github.com/elastic/kibana/pull/301737","mergeCommit":{"message":"[scout]
migrate x-pack/platform/test/accessibility/apps/group1/dashboard_links
to scout (#301737)\n\nCloses
https://github.com/elastic/kibana/issues/272644\nCloses
https://github.com/elastic/kibana/issues/276442\nCloses
https://github.com/elastic/kibana/issues/274967\n\nFixes flakiness by
removing save dashboard from test.\n\nAlso turns on links test in CI.
Turns out they have been disabled this\nentire time -
yikes","sha":"dad7b3d9badda36eac1f2853a6b289917205fffd"}},"sourceBranch":"main","suggestedTargetBranches":["9.6"],"targetPullRequestStates":[{"branch":"9.6","label":"v9.6.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.7.0","branchLabelMappingKey":"^v9.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/301737","number":301737,"mergeCommit":{"message":"[scout]
migrate x-pack/platform/test/accessibility/apps/group1/dashboard_links
to scout (#301737)\n\nCloses
https://github.com/elastic/kibana/issues/272644\nCloses
https://github.com/elastic/kibana/issues/276442\nCloses
https://github.com/elastic/kibana/issues/274967\n\nFixes flakiness by
removing save dashboard from test.\n\nAlso turns on links test in CI.
Turns out they have been disabled this\nentire time -
yikes","sha":"dad7b3d9badda36eac1f2853a6b289917205fffd"}}]}] BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes
@acstll acstll acstll approved these changes
@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes
@walterra walterra Awaiting requested review from walterra walterra is a code owner automatically assigned from elastic/kibana-dashboards

Assignees

No one assigned

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.6.0 v9.7.0

Projects

None yet

Milestone

No milestone

5 participants

@nreese @kibanamachine @maryam-saeidi @tylersmalley @acstll