Repository navigation
fix: acknowledge accepted updates and guard persistence leases - #32
Open
stanley2058 wants to merge 1 commit into
Open
stanley2058 wants to merge 1 commit into
stanley2058 wants to merge 1 commit into
Conversation
stanley2058
added this pull request to stack #34
October 5, 2026 07:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two transport correctness issues:
sync-updateretries could receive an ACK after the original Redis append failed or while it was still pending. Every attempt now appends to Redis and receives an ACK only after successful acceptance. Yjs safely merges duplicate updates.Adds 15 regression tests covering append failures, concurrent retries, lost ACKs, three server instances sharing Redis, lease expiry and reacquisition, delayed renewal, cleanup races, and a real Socket.IO reconnect. The tests run in CI with Redis.
Validated with the regression suite on Node 18,
npm run lint(Standard and TypeScript), andnpm run dist.The storage and worker APIs are unchanged. Lease ownership does not prevent an already-dispatched worker from committing stale state after lease expiry; storage-enforced commit ordering remains separate work. All servers must be upgraded before relying on owner-checked leases because older servers still release leases unconditionally.