Repository navigation
feat(helm): skip unrelated docs work and bundle formatting tools - #985
Conversation
220236e to
b325e70
Compare
|
Internal - Pull request - Continuous Integration - Test results Workflow run and full reports · Commit d0cc8f8 Jobs: 10 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned. Test: 235 passed · 0 failed · 0 skipped. Test detailsTest resultsTest Results
Job results and report availability
Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs. |
|
Internal - Pull request - Continuous Integration - Code coverage Workflow run and full reports · Commit d0cc8f8 Jobs: 10 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned. Coverage: 9 source report(s); percentages remain separate. Coverage detailsCoverage resultsci-reports-1-test-action-docker-promote-images-actions-docker-promote-images-6d2b4acc-f5b2-4989-82b1-da2a1ed00d1c/lcov.infoCoverage
Overall: 98.79% 🟢 ci-reports-1-test-action-docker-prune-pull-requests-image-tags-actions-docker-prune-pull-requests-image-tags-af17375f-527b-4c99-8849-431c493b4035/lcov.infoCoverage
Overall: 83.48% 🟢 ci-reports-1-test-action-docker-verify-images-actions-docker-verify-images-57dfaee7-9954-4681-ac28-161437598f6a/lcov.infoCoverage
Overall: 100.00% 🟢 ci-reports-1-test-action-helm-generate-docs-actions-helm-generate-docs-0b5e46ef-a6d7-4c3b-923d-15af29b02532/lcov.infoCoverage
Overall: 95.34% 🟢 ci-reports-1-test-action-helm-lint-chart-actions-helm-lint-chart-0fcc8c3a-fc6d-446d-9bde-0630de411565/lcov.infoCoverage
Overall: 96.50% 🟢 ci-reports-1-test-action-helm-prepare-chart-actions-helm-prepare-chart-ae1633c0-3584-459d-a9f3-61f3935905b2/lcov.infoCoverage
Overall: 87.93% 🟢 ci-reports-1-test-action-helm-prepare-release-actions-helm-prepare-release-3506162c-5f41-43ee-8713-7a7c75304329/lcov.infoCoverage
Overall: 94.54% 🟢 ci-reports-1-test-action-helm-release-chart-actions-helm-release-chart-fc23f3e2-5462-460d-ab2d-77769c381361/lcov.infoCoverage
Overall: 100.00% 🟢 ci-reports-1-test-action-helm-test-chart-actions-helm-test-chart-0360ba4b-b8e3-4dc1-b90e-4b0f74763350/lcov.infoCoverage
Overall: 98.85% 🟢 Job results and report availability
Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs. |
|
Internal - Pull request - Continuous Integration - Lint results Workflow run and full reports · Commit d0cc8f8 Jobs: 10 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned. Lint: Collected diagnostics and Super-Linter summaries. Execution status is included in the job outcomes. Super-Linter detailsSuper-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter Job results and report availability
Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs. |
b325e70 to
2b3fa10
Compare
Helm documentation generation now formats files from committed JavaScript, removing runtime Node.js setup, npm installation, npx calls and unused formatter caches. Callers can also opt out of generation for verified unrelated changes through
skip-if-only-changed; empty keeps generation unconditional.The change detector compares a clean default-branch push checkout against the same workflow's last successful push, preserving catch-up after failed/cancelled runs. Chart paths, explicit values files, renames and incomplete comparisons remain conservative. Reruns, local edits, release calls with checkout disabled and API/Git failures generate normally. Call after required checks on every default-branch push without independent path filters. Git checkout probes use private, fixed command arguments. ADR 0011 consolidates this contract and the formatter distribution decision.
Formatting uses supported Textlint, Markdownlint and Prettier APIs. Existing caller configuration, ignores, dictionaries and custom rules/plugins remain supported; custom dependencies must already exist in the caller checkout. Invalid configuration fails, while remaining Markdown style findings stay advisory. esbuild preserves native imports of caller modules; ncc remains a build-only dependency for license generation. The terminology dictionary is embedded through its public API. The same ADR records the bundling trade-offs and size (7.9 MiB JavaScript, 1.9 MiB gzip). Standard distribution checks and dependency-bot rebuild automation discover the package without new path lists.
Review follow-up: merged the bundling record into
docs/adr/0011-skip-unchanged-helm-documentation.md, retaining both decisions and dated evidence. Removed ADR 0012, updated the superseding link and development guide, and regenerated the action readme through ci-dokumentor. Documentation formatting, Markdown/text lint, action-metadata security checks, 23 relative links/anchors andgit diff --checkpass. Runtime source and the committed distribution are unchanged.The existing implementation validation covers 67 source tests and 67 isolated distribution tests on Node.js 24, 11 isolated formatter cases on Node.js 26, deterministic host/container rebuilds, and secret scanning. CodeQL marks the Git-helper alert as fixed. CI for documentation revision
4b1bf5cpassed all 232 executed jobs with 77 expected nested skips. No PR checks are failing or pending. No main bot publication or release was triggered; no workflow speedup is claimed from local checks.Pleey #553 previews this action. Release #985 and replace both preview pins before merging Pleey.